Skip to content

fix(desktop): chmod 755 spawn-helper after staging to fix macOS 26 node-pty failure #63789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liuhao1024 wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −2
Open

fix(desktop): chmod 755 spawn-helper after staging to fix macOS 26 node-pty failure #63789

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions apps/desktop/scripts/stage-native-deps.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import { createRequire } from 'node:module'
import { fileURLToPath } from 'node:url'
import { dirname, resolve, join } from 'node:path'
import {
chmodSync,
cpSync,
existsSync,
mkdirSync,
Expand Down Expand Up @@ -72,7 +73,11 @@ function copyBuildRelease(srcDir, destDir) {
continue
}
if (entry.name === 'spawn-helper' || /\.(node|dll|exe)$/.test(entry.name)) {
cpSync(join(srcDir, entry.name), join(destDir, entry.name))
const destPath = join(destDir, entry.name)
cpSync(join(srcDir, entry.name), destPath)
if (entry.name === 'spawn-helper') {
chmodSync(destPath, 0o755)
}
}
}
}
Expand Down Expand Up @@ -114,7 +119,9 @@ export function stageNodePty({ platform = process.platform, arch = process.arch
continue
}
if (entry.name === 'spawn-helper') {
cpSync(join(prebuildDir, entry.name), join(destPrebuild, entry.name))
const destPath = join(destPrebuild, entry.name)

@teknium1 teknium1 Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linked #63784 reproduction reports that packaged pty.spawn still fails after this helper is mode 0755, due to a separate sealed-bundle/path interaction. Please do not treat this chmod alone as validation of the claimed macOS 26 terminal fix; retain it as the executable-mode correction and separately prove the packaged-app outcome.

cpSync(join(prebuildDir, entry.name), destPath)
chmodSync(destPath, 0o755)
}
}
} else {
Expand Down
Loading