Skip to content

chore: add .install_method to .gitignore - #63785

Open
mike3504 wants to merge 1 commit into
NousResearch:mainfrom
mike3504:chore/gitignore-install-method
Open

chore: add .install_method to .gitignore#63785
mike3504 wants to merge 1 commit into
NousResearch:mainfrom
mike3504:chore/gitignore-install-method

Conversation

@mike3504

Copy link
Copy Markdown

The .install_method file is written by the bootstrap installer to record the installation method (git, npm, etc.). It's runtime state, not a code change, so it should be ignored like .hermes-bootstrap-complete.

What does this PR do?

Related Issue

Fixes #

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 🔒 Security fix
  • 📝 Documentation update
  • ✅ Tests (adding or improving test coverage)
  • ♻️ Refactor (no behavior change)
  • 🎯 New skill (bundled or hub)

Changes Made

How to Test

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run pytest tests/ -q and all tests pass
  • I've added tests for my changes (required for bug fixes, strongly encouraged for features)
  • I've tested on my platform:

Documentation & Housekeeping

  • I've updated relevant documentation (README, docs/, docstrings) — or N/A
  • I've updated cli-config.yaml.example if I added/changed config keys — or N/A
  • I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
  • I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
  • I've updated tool descriptions/schemas if I changed tool behavior — or N/A

For New Skills

  • This skill is broadly useful to most users (if bundled) — see Contributing Guide
  • SKILL.md follows the standard format (frontmatter, trigger conditions, steps, pitfalls)
  • No external dependencies that aren't already available (prefer stdlib, curl, existing Hermes tools)
  • I've tested the skill end-to-end: hermes --toolsets skills -q "Use the X skill to do Y"

Screenshots / Logs

The .install_method file is written by the bootstrap installer to record the
installation method (git, npm, etc.). It's runtime state, not a code change,
so it should be ignored like .hermes-bootstrap-complete.
@alt-glitch alt-glitch added type/bug Something isn't working comp/cli CLI entry point, hermes_cli/, setup wizard area/config Config system, migrations, profiles P3 Low — cosmetic, nice to have duplicate This issue or pull request already exists labels Jul 13, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

This was generated by AI during triage.

Duplicate of #54855 — identical one-line change adding .install_method to .gitignore for the same reason (the bootstrap-written stamp is untracked, so hermes update stashes it and prompts on every update). #54855 is the earlier open PR. Also related to the broader #51644, which gitignores the same file among other doctor-alignment changes.

@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the focused cleanup. The premise is valid on current main: hermes_cli/config.py:501 writes the code-tree .install_method, and hermes_cli/main.py:6486 autostashes untracked files during update; current .gitignore has no matching rule.

Problems

  • The change has no regression coverage. tests/hermes_cli/test_update_autostash.py:859-903 verifies the same git stash push --include-untracked contract for .hermes-bootstrap-complete, but does not cover .install_method.

Suggested changes

  • Add the analogous hermetic test for .install_method in tests/hermes_cli/test_update_autostash.py.

This is an automated hermes-sweeper review.

@teknium1 teknium1 added sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades sweeper:blast-contained Sweeper blast radius: contained — one narrow path / opt-in / few users area/install-update Installer, updater, packaging, wheels, doctor labels Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Config system, migrations, profiles area/install-update Installer, updater, packaging, wheels, doctor comp/cli CLI entry point, hermes_cli/, setup wizard duplicate This issue or pull request already exists P3 Low — cosmetic, nice to have sweeper:blast-contained Sweeper blast radius: contained — one narrow path / opt-in / few users sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants