Conversation
Adds French versions of the core documentation following the existing locale-suffix convention (README.es.md, CONTRIBUTING.es.md, SECURITY.es.md): - README.fr.md - CONTRIBUTING.fr.md - SECURITY.fr.md Translated from the current English sources by a native French speaker. Technical identifiers (commands, paths, env vars, provider/model names, URLs, code blocks) are kept verbatim. The English LICENSE remains the authoritative legal version. Closes NousResearch#60535 Signed-off-by: iacker <iacker@users.noreply.github.com>
teknium1
left a comment
There was a problem hiding this comment.
Thanks for adding a complete French set of the root documentation. The current English sources are unchanged from the PR base, so the translation remains current against main.
Problems
SECURITY.fr.md:359still directs readers toCONTRIBUTING.md; use the newly addedCONTRIBUTING.fr.md. The established Spanish counterpart localizes this same reference atSECURITY.es.md:311.- The canonical selector in
README.md:14-16has badges for Chinese, Urdu, and Spanish but not French. Add aREADME.fr.mdbadge there so the new translation is discoverable from the primary entry point.
Suggested changes
- Replace the security-policy cross-reference with
CONTRIBUTING.fr.md. - Extend the existing
README.mdlanguage badge block with French.
Automated hermes-sweeper review.
| journal d'audit d'installation constituent la surface de revue. | ||
| - Hermes Agent inclut des garde-fous de chaîne d'approvisionnement pour | ||
| le lancement des serveurs MCP et pour les changements de dépendances | ||
| / paquets embarqués en CI ; voir `CONTRIBUTING.md` pour les détails. |
There was a problem hiding this comment.
Please point this localized policy at the new CONTRIBUTING.fr.md. The equivalent Spanish policy already uses CONTRIBUTING.es.md, so leaving this as CONTRIBUTING.md unnecessarily sends French readers back to English.
Address hermes-sweeper review on NousResearch#63660: - SECURITY.fr.md: point security-policy cross-reference to CONTRIBUTING.fr.md (matching SECURITY.es.md localization convention) - README.md: add README.fr.md language badge so the French translation is discoverable from the primary entry point Signed-off-by: Billard <82095453+iacker@users.noreply.github.com>
|
Hello, can i help to review this. i'm a french native Canadian. i can help if you want. |
SummaryOne PR addresses issue #60535. #63660 adds French translations of README, CONTRIBUTING, and SECURITY, links the translated documents internally, and adds French discoverability to the primary README; the issue remains open despite a non-contributor comment claiming its subject is now CI-enforced. Related pull requests
Suggested consolidationKeep #63660 open with a salvage path: preserve its complete French documentation set and the two diff-visible fixes requested by the contributor review. It is the recorded best available fix and has no competing duplicate, but no merge recommendation is supported by the recorded lane finding. Complex graphflowchart LR
classDef open fill:#dbeafe,stroke:#1d4ed8,color:#1e3a8a
classDef merged fill:#dcfce7,stroke:#15803d,color:#14532d
classDef closed fill:#e5e7eb,stroke:#6b7280,color:#1f2937
classDef unverified fill:#f3f4f6,stroke:#9ca3af,color:#374151
classDef best stroke-width:3px,stroke:#b45309
classDef target stroke-width:3px,stroke:#4338ca
I60535(["issue #60535 (open)"])
P63660["PR #63660 (open)"]
P63660 -->|best fix| I60535
class I60535 open
class P63660 open
class P63660 best
class P63660 target
click I60535 "https://github.com/NousResearch/hermes-agent/issues/60535"
click P63660 "https://github.com/NousResearch/hermes-agent/pull/63660"
Graph: solid arrow = fixes / best fix, dashed arrow = partial or unverified (see edge label); boxed group = PRs duplicating each other; amber border = best fix; indigo border = target; gray node = closed (state tag in the node label). Cross-PR triage: Reviewed 1 pull request and 1 issue in this complex. Each diff was read against this issue; Assessment working set: 97 kB of PR diffs, 3 kB of issue/PR text, 2 kB of discussion (4 comments), 2 verify verdicts. verdicts reflect diff content, not PR titles. Part of an automated triage batch. |
|
Salvage record: your French translation was cherry-picked into the germination pipeline PR (#80391, closes #60535) with your commits' authorship preserved. The parity gate caught drift since your July base (Vercel Sandbox backend count, |
…ent localization Blind semantic review of the French translations (28 findings, zero meaning-changing technical errors) — all applied: - False friend: "éventuellement" -> "en option" (MemoryProvider post_setup). - Calques removed: harnais -> infrastructure de l'agent; plomberie -> infrastructure de configuration; exercez -> testez; amorçage phrasing; "un amont" -> "un service en amont"; "n'opère pas" -> "n'a pas de programme"; sandboxe -> n'isole que le shell. - Meaning shift: "exfiltration opportuniste" -> "exfiltration accidentelle" (casual != opportunistic). - Anglicisms: managé -> géré; template de PR -> gabarit de PR; gating -> verrouillage; Assets TTS -> Ressources TTS; sites d'appel -> points d'appel; "official" -> « officielle ». - Terminology standardized: allowlist -> « liste d'autorisation » everywhere (3 renderings collapsed to 1); "core" -> « cœur ». - Residual English: reload/start-chatting comments, skill-example comments, branch-type table, version-window comments, tree-structure comments, project-tree comments — all translated. - Recurring calque: "résoudre des approbations" -> « statuer sur les approbations » (3 sites). Gate refinement enabling this: fence comments are now LOCALIZABLE prose — comment-normalized body hashes (commands must match exactly, comments may be translated, comment code spans like `env -i` still required). This is the principled line: code never translated, comments are docs. chore: map contributor email iacker (credit ledger for NousResearch#63660 seed). Signed-off-by: Andrex Ibiza, MBA <84248988+andrexibiza@users.noreply.github.com>
|
Thanks @andrexibiza — really glad the French translation could serve as the seed. Happy to see it re-germinated against current main and gate-enforced; the drift you caught (Vercel Sandbox backend count, Closing this in favor of #80391 makes sense — authorship is preserved there. If it helps the top-10 rollout, I'm happy to germinate one of the still-pending locales (pt / id) through the pipeline and run the gate before opening anything. Just say the word so we don't duplicate the in-flight PRs. |
All language requests are now in-flight germination. Hermes is everywhere now. |
Superseded by #80391, which incorporates this French translation with its current-main parity pipeline and preserves the source work's authorship. |
|
Closing this since #80391 supersedes it and preserves the original authorship. |
Summary
Adds French translations of the core documentation, following the existing locale-suffix convention already used for Spanish (
README.es.md,CONTRIBUTING.es.md,SECURITY.es.md):README.fr.mdCONTRIBUTING.fr.mdSECURITY.fr.mdCloses #60535.
Approach
README.fr.mdmirrorsREADME.es.md: adds an English badge →README.md, keeps the existing 中文 / اردو / Español badges, and does not self-link a French badge.hermes setup,hermes model…), paths (~/.hermes/,config.yaml,%LOCALAPPDATA%\hermes), env vars (HERMES_*), provider/model names, URLs, and all code blocks (including in-code comments)..fr.mdversions where they now exist.LICENSEremains the authoritative legal version.Verification
README.md/CONTRIBUTING.md/SECURITY.mduntouched.