test(tools): shell-quote Windows sentinel paths passed to Bash

[LceAn]

What & why

These two regression tests interpolate a pathlib.Path into a Bash command. On native Windows, the terminal uses Git Bash: backslashes are consumed as escapes, and an unquoted path with spaces can be split into multiple arguments. The original as_posix() fix addressed separators but not shell metacharacters or spaces.

Change

• Pass both sentinels through shlex.quote(sentinel.as_posix()).
• Keep the tests as real post-start interrupt checks; sentinel filenames now include spaces so the quoting contract is exercised.

Validation

• Native Windows: the three focused approval/interrupt tests pass.
• ruff and py_compile pass.

This remains a focused test-only fix. Related direct Bash path interpolations in test_file_tools_live.py are separate follow-up work.

[LceAn]

Gentle ping for review. (Rebased onto current main — the branch is now mergeable again.)

Two things worth flagging on this one beyond the diff itself:

1. It fixes a double fault on Windows: the two tests fail (AssertionError: command did not start) AND each run leaks a junk file into the repo root, because Git Bash consumes the backslashes in the interpolated C:\Users\A\… path and touch writes a mangled, separator-less filename there. With as_posix() both tests pass and the leak stops (stray-file count before/after = 0).

2. The as_posix() pattern recurs elsewhere — tests/tools/test_file_tools_live.py has the same class of path-interpolation-into-bash bug (reported on Windows-native pytest suite has baseline failures in ACP, path, CRLF, and file-handle tests #48986 alongside an orthogonal CRLF issue). If the maintainers like this shape, I can extend it there in a follow-up.

No production code touched; no-op on POSIX where Path.as_posix() returns the native string unchanged.

[teknium1]

Thanks for the focused Windows regression fix. Current main still formats the two tmp_path sentinels directly into Bash command strings at tests/tools/test_approved_command_clean_slate.py:97 and :128; this diff updates exactly those sites. The existing Windows shell-path contract independently documents that Git Bash consumes backslashes in embedded paths at tools/environments/local.py:69-88.

No blocking issue found in this two-line test-only change. The related direct shell-path interpolations in tests/tools/test_file_tools_live.py:141, :413, :420, :428, and :435 remain a separate follow-up, consistent with the linked #48986 discussion.

Automated hermes-sweeper review.

[LceAn]

Maintenance update: rebased onto current main. The reviewed two-line as_posix() fix is unchanged and the branch remains a focused one-file diff. Ready for review.

[LceAn]

Second-pass maintenance: the original separator fix was not sufficient for spaces or shell metacharacters. The two sentinels now use shlex.quote(as_posix()), with space-containing filenames to prove the full contract; focused Windows tests pass.

[GottZ]

This was generated by AI during triage.

Summary

Three PRs are associated with this complex. #52000 and #52001 propagate session_id through execute_code and its local and remote nested-tool RPC paths, while #63641 only shell-quotes Windows sentinel paths in an unrelated test file.

Related pull requests

• fix(execute_code): forward session_id to nested tool calls via RPC #52000 best fix — (+204/-9) — n/a: Threads the explicit session_id through the registry handler, execute_code, and both nested RPC dispatch paths while retaining rpc_token authorization, directly addressing [Bug]: Nested tool hooks(on_pre_tool_call and on_post_tool_call) can't get session_id #51931. The updated diff also includes the registry-level regression requested by the contributor review, and the maintainer-bot review supports keeping this high-salvageability fix open.
• fix(execute_code): preserve session id for nested tools #52001 [closed] fixes — (+59/-5) — n/a: Implements substantially the same registry-to-local/remote-RPC session_id propagation as fix(execute_code): forward session_id to nested tool calls via RPC #52000; it remains relevant as corroborating reference work but is already closed as a duplicate of fix(execute_code): forward session_id to nested tool calls via RPC #52000.
• test(tools): shell-quote Windows sentinel paths passed to Bash #63641 related — (+7/-4) — n/a: Changes only tests/tools/test_approved_command_clean_slate.py by applying shlex.quote() to POSIX-normalized Windows sentinel paths; it does not modify execute_code or nested session propagation. Its keep_open review concerns this separate, focused Windows test fix and is not contradicted by excluding it from [Bug]: Nested tool hooks(on_pre_tool_call and on_post_tool_call) can't get session_id #51931 consolidation.

Duplicates

#52000 and #52001 implement substantially the same session_id propagation; #52001 is the closed duplicate of #52000. #63641 is not part of that duplicate set.

Suggested consolidation

Keep #52000 open with a salvage path: preserve its explicit registry contract, local and remote RPC propagation, rpc_token handling, and focused regressions; this follows the recorded best-fix designation and the maintainer-bot keep_open review without making a merge recommendation. Keep #52001 closed as duplicate of #52000, and keep #63641 open for separate triage of its reviewed Windows path-quoting fix rather than associating it with #51931.

Cross-PR triage: Reviewed 3 pull requests and 1 issue in this complex. Each diff was read against this issue; Assessment working set: 24 kB of PR diffs, 19 kB of issue/PR text, 8 kB of discussion (13 comments), 3 verify verdicts. verdicts reflect diff content, not PR titles. Part of an automated triage batch.