fix(kanban): harden worker runtime ownership and preflight - #63637
Open
stevenbaert wants to merge 5 commits into
Open
stevenbaert wants to merge 5 commits into
stevenbaert wants to merge 5 commits into
Conversation
Collaborator
|
Thanks for the detailed worker-ownership work. The current PR needs rework before its lifecycle changes can be salvaged. Problems
Suggested changes
Automated hermes-sweeper review. |
19 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This hardens the Kanban worker lifecycle so stale process IDs, reused PIDs, gateway restarts, and inherited provider routes cannot corrupt worker outcomes or terminate an unrelated process.
What changes
Verification
Rebased onto current
NousResearch/hermes-agent:mainand run from a clean worktree:Independent exact-head QA also reproduced the two prior PID-reuse races and validated the canonical provider/model/auth and parent→reviewer inheritance paths.
Risk and scope
The changes are limited to Kanban worker lifecycle/preflight behavior and its tests. No gateway configuration, secrets, deployment, or runtime activation is included.