Conversation
Add _bash_safe_path and _quote_bash_path to normalize native and mixed /c/Users\... paths before they are embedded in Git Bash scripts.
Wire _bash_safe_path into ShellFileOperations shell args and normalize snapshot/cwd-file paths in init_session/_wrap_command so Windows Git Bash no longer sees native backslashes in bootstrap or mixed /c/Users\... paths.
Contributor
|
Superseded by a scoped salvage that keeps your diagnosis and helpers, with two deltas:
Closing in favor of that PR (Co-authored-by preserved). Thanks for the sharp follow-up on the Discord logs. |
4 tasks
Contributor
|
Superseded — see the salvage PR linked above. |
Gravezzz
pushed a commit
to Gravezzz/hermes-agent
that referenced
this pull request
Jul 21, 2026
…470-bash-paths fix(windows): bash-safe snapshot paths after NousResearch#63113 (supersedes NousResearch#63470)
leewenjie
pushed a commit
to leewenjie/hermes-agent
that referenced
this pull request
Aug 7, 2026
…470-bash-paths fix(windows): bash-safe snapshot paths after NousResearch#63113 (supersedes NousResearch#63470)
randlee
pushed a commit
to randlee/hermes-agent
that referenced
this pull request
Aug 11, 2026
…470-bash-paths fix(windows): bash-safe snapshot paths after NousResearch#63113 (supersedes NousResearch#63470)
prmartinow
pushed a commit
to prmartinow/hermes-agent
that referenced
this pull request
Aug 26, 2026
…470-bash-paths fix(windows): bash-safe snapshot paths after NousResearch#63113 (supersedes NousResearch#63470)
melon-xf
added a commit
to melon-xf/hermes-agent
that referenced
this pull request
Sep 3, 2026
…470-bash-paths fix(windows): bash-safe snapshot paths after NousResearch#63113 (supersedes NousResearch#63470)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #63113 — users on
upstream 7b5ba205still hit\drivers\etcon Windows Desktop after that merge.Root cause: #63113 only rewrote native
C:\...paths inShellFileOperations._escape_shell_arg. Two gaps remained:init_session/_wrap_commandsnapshot paths —C:\Users\...\hermes-snap-*.shstill reached bash with backslashes, so snapshot bootstrap failed every turn./c/Users\Alexander\Documents\...bypassed_windows_to_msys_path(noC:prefix) but still carried\Ubackslashes bash mangled.This PR adds
_bash_safe_path/_quote_bash_pathinlocal.pyand wires them intofile_operations+base.pysnapshot quoting.Test plan
scripts/run_tests.sh tests/tools/test_local_env_windows_msys.py tests/tools/test_file_operations.py::TestShellArgEscaping tests/tools/test_init_session_cwd_respect.py -qwrite_filetoC:\Users\<user>\Documents\NewTEST\readme.txtsucceedsinit_sessionno longer fails with snapshot bootstrap exit 1 on first tool useMade with Cursor