fix(setup): remove saved custom provider from migrated config - #63287
Closed
ajzrva-sys wants to merge 1 commit into
Closed
fix(setup): remove saved custom provider from migrated config#63287ajzrva-sys wants to merge 1 commit into
ajzrva-sys wants to merge 1 commit into
Conversation
Support both legacy custom_providers list and migrated providers dict when listing and removing saved custom endpoints. Previously _remove_custom_provider only read from custom_providers, so providers that had been migrated to the providers: dict could not be removed — the menu would show 'No custom providers configured' even when entries existed. Now enumerates entries from both sections and removes from the correct source. Fixes NousResearch#5525
Contributor
Author
|
Closing in favor of #14360 which takes the same approach (get_compatible_custom_providers + dual-schema removal) and was filed first. Added my dedup test case as a suggestion there. |
1 task
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes removing a saved custom provider in
hermes setup model.Hermes stores named custom endpoints in two formats:
custom_providers:listproviders:dict (after config migration)The remove flow previously only edited
custom_providers, so migrated providers could not be removed — the menu would show 'No custom providers configured' even when entries existed inproviders:.This PR:
custom_providersandprovidersFixes #5525