feat(update): add opt-out for gateway shutdown notices - #63165
Open
metamindedu wants to merge 3 commits into
Open
feat(update): add opt-out for gateway shutdown notices#63165metamindedu wants to merge 3 commits into
metamindedu wants to merge 3 commits into
Conversation
Contributor
|
Thanks for keeping the control narrowly scoped to update-initiated Windows gateway pauses. The current main path still writes an update planned-stop marker in Problems
Suggested changes
Automated hermes-sweeper review. |
Contributor
Author
|
Addressed the lifecycle coverage gap in
Verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Windows Desktop/CLI updates intentionally pause running gateways before mutating the install. Today that planned stop follows the same notification path as manual or unexpected shutdowns, so active chats receive:
This PR makes that update-specific notice configurable while preserving existing behavior by default.
New setting
The setting is also exposed as Settings → Advanced → Update Shutdown Notifications in Hermes Desktop.
true(default)falseImplementation
config.yamlbefore writing the planned-stop marker.suppress_notification: trueonly when that profile explicitly disablesupdates.gateway_shutdown_notification.resume_pending, cleanup, exit status, and post-update gateway restart behavior are unchanged.Compatibility
true, so existing installs behave exactly as before.hermes gateway stop, service stops, normal restarts, and unexpected shutdowns do not set the update suppression flag and keep their existing notifications.Related work / de-duplication
Tests
assert-dist-builtincluded).py_compile, andgit diff --check: passed.The Desktop build emitted only existing non-blocking CSS/chunk-size warnings and reported zero dependency vulnerabilities after a clean root
npm ci.