Skip to content

fix(desktop): keep answered clarify Q&A visible in the transcript - #63102

Merged
OutThisLife merged 3 commits into
mainfrom
bb/clarify-answer-visible
Jul 12, 2026
Merged

fix(desktop): keep answered clarify Q&A visible in the transcript#63102
OutThisLife merged 3 commits into
mainfrom
bb/clarify-answer-visible

Conversation

@OutThisLife

@OutThisLife OutThisLife commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Answered clarify prompts settle into an inline Q&A panel instead of collapsing into a generic "Asked a question" tool row
  • Freeform clarify input uses the shared Textarea chrome (controlVariants / desktop-input-chrome) instead of a bare p-0 textarea
  • Settled answers show a CircleLetterA icon beside the response, mirroring the question icon

Test plan

  • npm run test:ui -- src/components/assistant-ui/clarify-tool.test.tsx
  • Trigger a clarify prompt in desktop, answer it, confirm question + answer stay visible in the transcript
  • Skip a clarify prompt and confirm it renders as "Skipped"
  • Open-ended clarify uses the shared textarea chrome; choice + Other paths still work

Answered clarifies were collapsing into a generic tool row, hiding the
choice. Settle into a Q&A panel instead, and route freeform input through
the shared Textarea chrome.
CI typecheck requires argsText, status, addResult, and resume on rendered
tool parts.
@OutThisLife
OutThisLife enabled auto-merge July 12, 2026 09:36
@alt-glitch alt-glitch added type/bug Something isn't working comp/desktop Electron desktop app (apps/desktop/*) P3 Low — cosmetic, nice to have labels Jul 12, 2026
@OutThisLife
OutThisLife merged commit fc232f8 into main Jul 12, 2026
20 checks passed
@OutThisLife
OutThisLife deleted the bb/clarify-answer-visible branch July 12, 2026 09:39
santhreal pushed a commit to santhreal/hermes-agent that referenced this pull request Jul 13, 2026
…swer-visible

fix(desktop): keep answered clarify Q&A visible in the transcript
shelizi pushed a commit to shelizi/hermes-agent that referenced this pull request Jul 14, 2026
…swer-visible

fix(desktop): keep answered clarify Q&A visible in the transcript
Gravezzz pushed a commit to Gravezzz/hermes-agent that referenced this pull request Jul 21, 2026
…swer-visible

fix(desktop): keep answered clarify Q&A visible in the transcript
leewenjie pushed a commit to leewenjie/hermes-agent that referenced this pull request Aug 7, 2026
…swer-visible

fix(desktop): keep answered clarify Q&A visible in the transcript
randlee pushed a commit to randlee/hermes-agent that referenced this pull request Aug 11, 2026
…swer-visible

fix(desktop): keep answered clarify Q&A visible in the transcript
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/desktop Electron desktop app (apps/desktop/*) P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants