fix: add missing send_voice() override to WhatsApp adapter - #6305
Closed
duan78 wants to merge 1 commit into
Closed
Conversation
WhatsApp adapter was missing a send_voice() override, causing TTS audio files to be sent as plain text (e.g. "🔊 Audio: /path/to/file.ogg") instead of native voice messages. All other media methods (send_image, send_image_file, send_video, send_document) were already properly overridden to use _send_media_to_bridge(). Fixes NousResearch#4979
13 tasks
Contributor
Collaborator
|
Likely duplicate of #13002 — same WhatsApp send_voice() fix already merged. |
Collaborator
|
Likely duplicate of #13002 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WhatsApp adapter (
gateway/platforms/whatsapp.py) was missing asend_voice()override. All other media methods (send_image,send_image_file,send_video,send_document) were properly overridden to use_send_media_to_bridge(), butsend_voicewas missed.This caused TTS audio files generated by the
text_to_speechtool to be sent as plain text (e.g.🔊 Audio: /path/to/file.ogg) instead of native WhatsApp voice notes.Fix
Added
send_voice()override following the exact same pattern assend_video():Related
send_voice()fix ([Bug]: TTS doesn't work with Matrix (Synapse) because of missing Content-Length #4339)Fixes #4979