fix(desktop): submit first message after session creation - #63045
Closed
sidharthgehlot wants to merge 1 commit into
Closed
fix(desktop): submit first message after session creation#63045sidharthgehlot wants to merge 1 commit into
sidharthgehlot wants to merge 1 commit into
Conversation
Allow the intentional new-chat route promotion without weakening session-switch isolation. Validate the created runtime and canonical stored-session route before continuing, and cover both successful promotion and a late user switch with regression tests.
Contributor
|
Thanks for the focused reproducer and race coverage. Current
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The submit pipeline pinned the new-chat route before
session.create. Creation then correctly navigated to the new stored session, but the pipeline interpreted that expected route change as user-driven context drift, cancelled the first submission, and restored the text to the composer.Test plan
npx vitest run --environment jsdom src/app/session/hooks/use-prompt-actions/index.test.tsx(44 passed)npm run typecheckgit diff --cached --check