fix(62256): ci: typecheck workflow lacks a concurrency group and job timeouts - #62952
vystartasv wants to merge 1 commit into
Conversation
teknium1
left a comment
There was a problem hiding this comment.
Thanks for addressing the missing timeout and stale-run controls. The timeout additions target a real current-main gap, but the concurrency group needs one correction.
Problems
.github/workflows/typecheck.yml:5uses${{ github.workflow }}-${{ github.ref }}. This reusable workflow is called by.github/workflows/ci.yml:77, whose group isci-${{ github.ref }}at.github/workflows/ci.yml:25-27. GitHub documents that a called workflow uses its caller'sgithub.workflow; therefore this resolves to the same case-insensitive group andcancel-in-progress: truecancels the caller CI run.
Suggested changes
- Use a distinct group such as
typecheck-${{ github.ref }}at.github/workflows/typecheck.yml:5, as proposed in issue #62256.
Automated hermes-sweeper review.
| name: Typecheck | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} |
There was a problem hiding this comment.
github.workflow is the caller workflow name inside a reusable workflow. Here it resolves to CI, which collides case-insensitively with the caller's ci-${{ github.ref }} group in ci.yml; with cancellation enabled this cancels the caller as the child starts. Use a distinct literal prefix such as typecheck-${{ github.ref }}.
Duplicate of #62257 — both fix #62256 by adding the same |
|
Closing — duplicate of #62257 (per alt-glitch triage) |
Fixes #62256
Changes
Auto-generated by Hermes Harness — reviewed by AI gate before submission.