Skip to content

fix(62256): ci: typecheck workflow lacks a concurrency group and job timeouts - #62952

Closed
vystartasv wants to merge 1 commit into
NousResearch:mainfrom
vystartasv:fix-62256-ci-typecheck-workflow-lacks-a-concu
Closed

vystartasv wants to merge 1 commit into
NousResearch:mainfrom
vystartasv:fix-62256-ci-typecheck-workflow-lacks-a-concu

Conversation

@vystartasv

Copy link
Copy Markdown

Fixes #62256

Changes

.github/workflows/typecheck.yml | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

Auto-generated by Hermes Harness — reviewed by AI gate before submission.

@teknium1 teknium1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the missing timeout and stale-run controls. The timeout additions target a real current-main gap, but the concurrency group needs one correction.

Problems

  • .github/workflows/typecheck.yml:5 uses ${{ github.workflow }}-${{ github.ref }}. This reusable workflow is called by .github/workflows/ci.yml:77, whose group is ci-${{ github.ref }} at .github/workflows/ci.yml:25-27. GitHub documents that a called workflow uses its caller's github.workflow; therefore this resolves to the same case-insensitive group and cancel-in-progress: true cancels the caller CI run.

Suggested changes

  • Use a distinct group such as typecheck-${{ github.ref }} at .github/workflows/typecheck.yml:5, as proposed in issue #62256.

Automated hermes-sweeper review.

name: Typecheck

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github.workflow is the caller workflow name inside a reusable workflow. Here it resolves to CI, which collides case-insensitively with the caller's ci-${{ github.ref }} group in ci.yml; with cancellation enabled this cancels the caller as the child starts. Use a distinct literal prefix such as typecheck-${{ github.ref }}.

@alt-glitch alt-glitch added type/feature New feature or request sweeper:risk-automation Sweeper risk: may affect CI, automerge, label sync, or maintainer automation P3 Low — cosmetic, nice to have duplicate This issue or pull request already exists labels Jul 12, 2026
@alt-glitch

Copy link
Copy Markdown
Contributor

This was generated by AI during triage.

Duplicate of #62257 — both fix #62256 by adding the same concurrency group (cancel-in-progress: true) and timeout-minutes: 10 to the two jobs in .github/workflows/typecheck.yml. #62257 (2026-07-10) is the earlier, canonical fix; this one (2026-07-12) re-implements the identical change. Related: #62256 (spec), #62102 (sibling timeout work).

@teknium1 teknium1 added the sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform label Jul 12, 2026
@vystartasv

Copy link
Copy Markdown
Author

Closing — duplicate of #62257 (per alt-glitch triage)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate This issue or pull request already exists P3 Low — cosmetic, nice to have sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform sweeper:risk-automation Sweeper risk: may affect CI, automerge, label sync, or maintainer automation type/feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: typecheck workflow lacks a concurrency group and job timeouts

3 participants