Skip to content

fix(agent): add return_exceptions=True to asyncio.gather in context reference expansion #62902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
x7peeps wants to merge 2 commits into from
Closed

fix(agent): add return_exceptions=True to asyncio.gather in context reference expansion #62902

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
accba5b
fix(agent): add return_exceptions=True to asyncio.gather in context r…
x7peeps Jul 11, 2026
b018488
Merge branch 'main' into fix/agent/add-return-exceptions-to-context-r…
x7peeps Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions agent/context_references.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,9 +167,14 @@ async def preprocess_context_references_async(
allowed_root=allowed_root_path,
)
for ref in refs
)
),
return_exceptions=True,
)

@teknium1 teknium1 Jul 11, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_expand_reference() already catches all Exception subclasses for its implemented branches (agent/context_references.py:225-243), so this primarily changes handling for cancellation/control-flow exceptions. Please add a reproducer for an exception that can escape on current main, or preserve and test cancellation propagation explicitly.

for warning, block in expanded:
for item in expanded:
if isinstance(item, BaseException):
warnings.append(f"reference expansion failed: {item}")
continue
warning, block = item
if warning:
warnings.append(warning)
if block:
Expand Down
Loading