fix(memory): restore flush memory persistence - #6273
Closed
bobashopcashier wants to merge 1 commit into
Closed
Conversation
bobashopcashier
force-pushed
the
codex/fix-memory-flush-correctness
branch
from
April 8, 2026 20:14
7cceb94 to
02e451c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
auxiliary.flush_memories.timeoutinflush_memories()for both the auxiliary path and the direct chat-completions fallbackIssues Addressed
Related PR Overlap
#6157fix proposed in fix(gateway): init memory store for flush agent #6179.#6154fix proposed in fix(agent): respect config timeout for flush_memories #6177.Why
The gateway flush path was constructing a temporary agent with memory disabled, which made memory tool calls fail during pre-reset flushes. Separately, the flush helper hardcoded a 30 second timeout and ignored the configured auxiliary timeout.
Testing
source .venv/bin/activate && python -m pytest tests/run_agent/test_flush_memories_codex.py tests/gateway/test_flush_memory_stale_guard.py -qNotes