Skip to content

fix(memory): restore flush memory persistence - #6273

Closed
bobashopcashier wants to merge 1 commit into
NousResearch:mainfrom
bobashopcashier:codex/fix-memory-flush-correctness
Closed

fix(memory): restore flush memory persistence#6273
bobashopcashier wants to merge 1 commit into
NousResearch:mainfrom
bobashopcashier:codex/fix-memory-flush-correctness

Conversation

@bobashopcashier

@bobashopcashier bobashopcashier commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • enable built-in memory for the gateway pre-reset flush agent so memory tool calls can persist writes
  • honor auxiliary.flush_memories.timeout in flush_memories() for both the auxiliary path and the direct chat-completions fallback
  • add focused regressions for gateway flush agent construction and timeout propagation

Issues Addressed

Related PR Overlap

Why

The gateway flush path was constructing a temporary agent with memory disabled, which made memory tool calls fail during pre-reset flushes. Separately, the flush helper hardcoded a 30 second timeout and ignored the configured auxiliary timeout.

Testing

  • source .venv/bin/activate && python -m pytest tests/run_agent/test_flush_memories_codex.py tests/gateway/test_flush_memory_stale_guard.py -q

Notes

  • This PR is intentionally scoped to the memory flush correctness path only.
  • Separate restart/dedup flush issues are not included here.

@bobashopcashier
bobashopcashier force-pushed the codex/fix-memory-flush-correctness branch from 7cceb94 to 02e451c Compare April 8, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant