Skip to content

feat(cron): support per-job reasoning effort - #62623

Closed
herbalizer404 wants to merge 3 commits into
NousResearch:mainfrom
herbalizer404:feat/per-cron-reasoning-effort
Closed

feat(cron): support per-job reasoning effort#62623
herbalizer404 wants to merge 3 commits into
NousResearch:mainfrom
herbalizer404:feat/per-cron-reasoning-effort

Conversation

@herbalizer404

Copy link
Copy Markdown
Contributor

Summary

Adds an optional reasoning_effort override to individual cron jobs, without changing the inherited global default.

  • Persists and normalizes a per-job override through the cron model, CLI, and native cronjob tool.
  • Propagates the override into scheduled agent runs; missing/cleared values retain global inheritance.
  • Supports canonical levels including max; none (and legacy stored false) explicitly disables reasoning.
  • Safely falls back to the global configuration for malformed stored values, including unhashable JSON lists/dicts.
  • Documents the feature and adds CLI, tool, persistence, and scheduler regression coverage.

Validation

scripts/run_tests.sh tests/cron/test_jobs.py tests/cron/test_scheduler.py tests/cron/test_cron_reasoning_effort.py tests/hermes_cli/test_cron.py tests/hermes_cli/test_cron_parser_builder.py tests/tools/test_cronjob_tools.py
461 passed, 0 failed

Also passed:

  • git diff --check origin/main..HEAD
  • Windows-footgun check

Compatibility

  • No override / cleared override: inherits the existing global reasoning setting.
  • none / legacy false: explicit disable.
  • Invalid hand-edited stored values: safely inherit instead of crashing the scheduler.

@tonydwb

tonydwb commented Jul 11, 2026

Copy link
Copy Markdown

Code Review Summary\n\nFound potential security issues. Please review.\n\n---\nReviewed by Hermes Agent

@alt-glitch alt-glitch added type/feature New feature or request comp/cron Cron scheduler and job management duplicate This issue or pull request already exists P3 Low — cosmetic, nice to have labels Jul 11, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

This was generated by AI during triage.

Duplicate of #7382 (the earliest open PR for per-job cron reasoning_effort overrides — same feature, same mechanism at the same cron sites). Sibling entrants #26214 and #30929 are already marked duplicates of #7382; tracking issue #23524 has the demand thread. The max level and malformed-value fallback here are nice touches but don't change that this is the same feature. Canonical remains #7382.

@herbalizer404

Copy link
Copy Markdown
Contributor Author

Closing as a duplicate of #7382, which is the canonical upstream proposal for per-job cron reasoning_effort overrides. The local rollout here remains separately tested with explicit handling for max, legacy false, and malformed stored values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Config system, migrations, profiles comp/cli CLI entry point, hermes_cli/, setup wizard comp/cron Cron scheduler and job management duplicate This issue or pull request already exists P3 Low — cosmetic, nice to have type/feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants