fix(61284): [Bug]: Dashboard chat sessions fail to render due to recent WebSocket re

[vystartasv]

Fixes #61284

Changes

ui-tui/packages/hermes-ink/src/ink/terminal.ts | 22 +++++++++++++++++++++-
 1 file changed, 21 insertions(+), 1 deletion(-)

Auto-generated by Hermes Harness — reviewed by AI gate before submission.

[tonydwb]

Code Review Summary

Looks good! No obvious issues found (reviewed in read-only mode).

---

Reviewed by Hermes Agent

[tonydwb]

Code Review Summary\n\nLooks good! No obvious issues found (reviewed in read-only mode).\n\n---\nReviewed by Hermes Agent

[alt-glitch]

This was generated by AI during triage.

Related to the #61284 fix cluster. This takes a client-side approach (queue writeDiffToTerminal output behind a ptyReady gate in ui-tui/.../ink/terminal.ts, flush on setPtyReady()), which is a different mechanism from the canonical backend fixes #60745 / #61045 / #61320 (key the keep-alive PTY registry on resume+profile in hermes_cli/web_server.py). Not a duplicate — a competing/complementary layer. Flagging the cluster so a maintainer can decide whether the client-side queue is still needed once the backend readiness handshake lands.

[tonydwb]

Code Review Summary

Looks good! No obvious issues found (reviewed in read-only mode).

---

Reviewed by Hermes Agent

[tonydwb]

Code Review Summary\n\nLooks good! No obvious issues found (reviewed in read-only mode).\n\n---\nReviewed by Hermes Agent

[teknium1]

Thanks for investigating the dashboard session-switch regression. The current implementation needs rework before it can address the reported path.

Problems

• setPtyReady() is added in ui-tui/packages/hermes-ink/src/ink/terminal.ts:216, but this PR changes only that file and provides no caller. The new ptyReady flag therefore remains false, causing the added writeDiffToTerminal() branch to queue output indefinitely. writeDiffToTerminal() is the normal render path in ui-tui/packages/hermes-ink/src/ink/ink.tsx:1134, so this is not dashboard-only.
• Current main’s session-switch problem is in keep-alive identity: web/src/pages/ChatPage.tsx:805 sends an attach token, and hermes_cli/web_server.py:15452 uses that token alone for PTY_REGISTRY.attach_or_spawn(). The registry returns an alive same-key session at hermes_cli/pty_session.py:151-153, regardless of requested resume/profile.

Suggested changes

• Rework this around the PTY registry key (resume + profile + attach token) and add regression coverage next to tests/test_pty_keepalive_ws.py:7 for same-token connections targeting different sessions/profiles.
• Avoid adding a shared Ink output gate without a concrete dashboard protocol and a caller that opens it.

Automated hermes-sweeper review.

[teknium1]

setPtyReady() has no caller in this one-file PR, so ptyReady stays false and every render is queued by the new writeDiffToTerminal() branch. Because this module is used by normal Ink rendering, this suppresses output beyond the dashboard path.