fix(openviking): read recall settings from config.yaml first, env vars as fallback

[justemu]

Summary

OpenVikingMemoryProvider._recall_config() previously read all recall settings (recall_limit, score_threshold, recall_resources, etc.) exclusively from environment variables. This forced users to store behavioural configuration in .env, violating the Hermes convention that .env is for secrets only.

Root Cause

The infrastructure to load config.yaml → memory.openviking was already in place via _load_hermes_openviking_config(), and was used by _resolve_connection_settings() for connection parameters. But _recall_config() never called it — it only read env vars.

Fix

_recall_config() now calls _load_hermes_openviking_config() and passes config.yaml values as the default parameter to the existing _env_int/_env_float/_env_bool helpers. Env vars still override config.yaml values, preserving backward compatibility.

Priority

config.yaml → env var → built-in default. This matches how _resolve_connection_settings() already uses config.yaml for connection parameters.

Closes

Closes #62540

[teknium1]

Thanks for addressing a confirmed configuration gap. Current main's plugins/memory/openviking/__init__.py:2587 reads recall policy exclusively through OPENVIKING_RECALL_*; the existing config loader at :855 is not used there.

Problems

• The changed config-resolution behavior is untested. tests/openviking_plugin/test_openviking.py:343 checks only defaults and schema entries, not memory.openviking values or the intended legacy env-var override.

Suggested changes

• Add a temp-HERMES_HOME test that writes memory.openviking recall settings in config.yaml, verifies _recall_config() consumes them, and verifies an OPENVIKING_RECALL_* value overrides config when present.

Automated hermes-sweeper review.

[teknium1]

Please add coverage for this new loader path using a temporary HERMES_HOME config.yaml, including the intended legacy environment-variable override. The existing recall-policy test only verifies built-in defaults.

[justemu]

Addressed the sweeper's review:

• 3 new tests added to TestOpenVikingConfigSchema:
  • test_recall_config_reads_from_config_yaml: writes memory.openviking settings in config.yaml, verifies _recall_config() consumes them.
  • test_recall_config_env_overrides_config_yaml: verifies OPENVIKING_RECALL_* env var overrides config.yaml value.
  • test_recall_config_partial_config_yaml: partial config.yaml falls back to defaults for omitted keys.
• All 46 openviking_plugin tests pass (43 existing + 3 new).
• Zero regressions.

[kshitijk4poor]

Merged via #77747 — your commits cherry-picked with authorship preserved (rebase merge).

This PR consolidated your recall settings from config.yaml fix together with 5 other OpenViking fixes into one coherent integration so the complete runtime behavior could be validated as a unit.

Thanks for the contribution!