Skip to content

fix(desktop): shorten darwin pty helper path - #62442

Open
LeonSGP43 wants to merge 1 commit into
NousResearch:mainfrom
LeonSGP43:fix/62429-node-pty-helper-path
Open

LeonSGP43 wants to merge 1 commit into
NousResearch:mainfrom
LeonSGP43:fix/62429-node-pty-helper-path

Conversation

@LeonSGP43

Copy link
Copy Markdown
Contributor

Summary

  • stage a second darwin spawn-helper copy under dist/bin during desktop packaging
  • patch the staged node-pty unixTerminal.js to prefer that shorter helper path on macOS
  • verify the packaging contract with focused staging tests and desktop bundle assertions

Verification

  • node --test apps/desktop/scripts/stage-native-deps.test.mjs
  • node --check apps/desktop/scripts/stage-native-deps.mjs
  • node --check apps/desktop/scripts/stage-native-deps.test.mjs
  • node --check apps/desktop/scripts/test-desktop.mjs
  • git diff --check

Closes #62429

@alt-glitch alt-glitch added type/bug Something isn't working comp/desktop Electron desktop app (apps/desktop/*) P3 Low — cosmetic, nice to have labels Jul 11, 2026
@teknium1

Copy link
Copy Markdown
Collaborator

Thanks for the focused macOS packaging fix. Current main still resolves node-pty’s helper from its nested native directory (node_modules/node-pty/lib/unixTerminal.js:29-32), while the desktop staging path remains under dist/node_modules/node-pty (apps/desktop/scripts/stage-native-deps.mjs:82-118). The proposed dist/bin/spawn-helper fallback is included by the existing dist/** package and unpack rules (apps/desktop/package.json:170-195), and the PR adds both staging and packaged-bundle assertions.

No verified problems found in the diff. This is an automated hermes-sweeper review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/desktop Electron desktop app (apps/desktop/*) P3 Low — cosmetic, nice to have sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades sweeper:risk-platform-windows Sweeper risk: may break or behave differently on native Windows type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Desktop terminal fails on macOS 26: posix_spawn rejects long helper path (node-pty spawn-helper)

3 participants