Conversation
teknium1
reviewed
Jul 11, 2026
teknium1
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for building this on the existing proxy-adapter and credential-pool surfaces.
Problems
hermes_cli/proxy/server.py:354-361records every request's configured client label, a stable derived fingerprint, model, and status. This is per-client usage attribution, butAGENTS.md:118-121requires a generic user-facing opt-in before adding attribution logging.- The public proxy guide remains inaccurate:
website/docs/user-guide/features/subscription-proxy.md:75-77says onlynousandxaiare shipped. It also needs the Codex-only key-file requirement and supported-path behavior.
Suggested changes
- Remove the attribution log. A generic opt-in mechanism would need to exist before this data can be recorded.
- Update the subscription-proxy documentation for
openai-codex,/responses//models, and--client-keys-filemode0600.
This is an automated hermes-sweeper review.
|
|
||
| await resp.write_eof() | ||
| fingerprint = hashlib.sha256(client_label.encode()).hexdigest()[:12] | ||
| logger.info( |
Collaborator
There was a problem hiding this comment.
Please remove this per-request client-label/fingerprint/model log. AGENTS.md:118-121 prohibits new usage attribution without the generic user-facing opt-in gate; this proxy does not provide that prerequisite.
- keep authentication failures generic and avoid client/model usage records - document the OpenAI Codex proxy paths and required owner-only key file - cover the no-attribution behavior in proxy tests
Author
|
Addressed in ea35e78:
Verification: |
19 tasks
This was referenced Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openai-codexupstream tohermes proxyWhy
Multi-user Hermes hosts need Linux-user isolation for mail, memory, 1Password, and other per-person secrets. Copying rotating Codex OAuth tokens into every user home is unsafe and operationally fragile. A single ops-owned proxy lets isolated Hermes clients share company-owned subscription accounts while keeping refresh tokens centralized.
Safety
Verification
response.completedand exact expected output through OpenAI Codex OAuthcodex_responsescalls through the same proxy