Skip to content

fix(photon): mark adapter as not supporting message editing to suppress streaming cursor #62172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
liuhao1024 wants to merge 1 commit into from
+16 −0
Closed

fix(photon): mark adapter as not supporting message editing to suppress streaming cursor #62172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions plugins/platforms/photon/adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,10 @@ class PhotonAdapter(BasePlatformAdapter):
"""

MAX_MESSAGE_LENGTH = _MAX_MESSAGE_LENGTH
# Photon (iMessage) has no real edit API for already-sent messages.
# Mark it explicitly so streaming suppresses the visible cursor instead
# of leaving a stale tofu square (▉) behind when edit attempts fail.
SUPPORTS_MESSAGE_EDITING = False

def __init__(self, config: PlatformConfig):
super().__init__(config, Platform("photon"))
Expand Down
12 changes: 12 additions & 0 deletions tests/plugins/platforms/photon/test_streaming.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
"""Regression tests for Photon adapter streaming behavior."""
from plugins.platforms.photon.adapter import PhotonAdapter


def test_photon_adapter_does_not_support_message_editing() -> None:
"""PhotonAdapter.SUPPORTS_MESSAGE_EDITING must be False.

Photon (iMessage) has no real edit API for already-sent messages.
This attribute signals the gateway to suppress the streaming cursor
instead of leaving a stale tofu square (▉) behind when edit attempts fail.
"""
assert PhotonAdapter.SUPPORTS_MESSAGE_EDITING is False
Loading