-
Notifications
You must be signed in to change notification settings - Fork 52.9k
fix: make Slack platform capability note tool-aware #62135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
tgasgarth-coatue
wants to merge
1
commit into
NousResearch:main
from
tgasgarth-coatue:fix/slack-platform-capability-note
+14
−7
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -294,8 +294,11 @@ def test_slack_prompt_includes_platform_notes(self): | |
| prompt = build_session_context_prompt(ctx) | ||
|
|
||
| assert "Slack" in prompt | ||
| assert "cannot search" in prompt.lower() | ||
| assert "pin" in prompt.lower() | ||
| assert "does not automatically expose a native slack api tool" in prompt.lower() | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This test covers only the single generic note. Add separate tool-present and tool-absent cases so the regression contract verifies that no-tool sessions remain conservative while scoped Slack-tool sessions are acknowledged. |
||
| assert "inspect the available tools and skills first" in prompt.lower() | ||
| assert "bounded helper when present" in prompt.lower() | ||
| assert "do not infer lack of access" in prompt.lower() | ||
| assert "write or admin actions" in prompt.lower() | ||
| assert "current message's slack block/attachment payload" in prompt.lower() | ||
|
|
||
| def test_discord_prompt_with_channel_topic(self): | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This note is emitted for every Slack session, regardless of whether a scoped Slack tool is actually exposed. Please select it from an explicit, stable loaded-tool capability signal so no-tool sessions retain the conservative disclaimer required by #6533.