fix(email): add splits_long_messages = True to prevent hard-truncation at 4000 chars (#61990) - #62037
Closed
webtecnica wants to merge 1 commit into
Closed
Conversation
Collaborator
Duplicate of #62000 — both add the identical one-line |
Contributor
|
Thanks for isolating the missing capability declaration. Problems
Suggested changes
Automated hermes-sweeper review. |
Contributor
Author
|
Closing as duplicate — the sweeper identified this as already covered by another PR. Thanks for the contribution! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Email delivery was hard-truncating outgoing messages at ~4000 characters because
EmailAdapterdid not declaresplits_long_messages = True. SMTP has no practical per-message limit at that scale — the adapter itself definesMAX_MESSAGE_LENGTH = 50_000.Root Cause
gateway/delivery.pychecksadapter.splits_long_messages: when False (default), content is hard-truncated to 4000 chars with a[... truncated]footer. All chat adapters (Telegram, Discord, Slack, etc.) set this to True; EmailAdapter was missing it.Change
Added
splits_long_messages = Trueas a class attribute onEmailAdapter.Verification
Lint passes clean. No test suite exists for email adapter yet.