fix(reasoning): expose max effort for GPT-5.6 - #61996
Conversation
Duplicate of #61638 (earlier open PR, created 2026-07-09, also |
teknium1
left a comment
There was a problem hiding this comment.
Thanks for addressing a real synchronization gap: current main accepts max in hermes_constants.py:794-819 and passes it through the Codex Responses transport at agent/transports/codex.py:155-166, while the gateway whitelist at gateway/slash_commands.py:2732 rejects it.
Problems
- The proposed gateway change continues a duplicated vocabulary. Please use
VALID_REASONING_EFFORTSrather than another literal set; the current split is the defect being fixed. - The change is incomplete across current UI surfaces.
web/src/lib/reasoning-effort.ts:17-35omitsmaxand normalizes it tomedium; desktop settings omit it atapps/desktop/src/app/settings/model-settings.tsx:85. The user guide also saysmaxis not selectable atwebsite/docs/user-guide/configuration.md:1284-1292.
Suggested changes
- Reuse the shared effort tuple in the gateway validator, then cover dashboard/desktop persistence or explicitly scope and document the supported surfaces.
Automated hermes-sweeper review.
| @@ -2733,7 +2733,7 @@ def _save_config_key(key_path: str, value): | |||
| return t("gateway.reasoning.reset_done") | |||
There was a problem hiding this comment.
Please use hermes_constants.VALID_REASONING_EFFORTS here instead of extending this local set. max is already canonical at hermes_constants.py:794; retaining a second vocabulary recreates the drift this PR fixes.
|
Closing — fully superseded. GPT-5.6 |
Summary
maxreasoning effort in the gateway/reasoningcommandmaxto CLI help, validation output, completion, and the interactive reasoning pickerTesting
uv run --extra dev pytest tests/test_hermes_constants.py tests/cli/test_reasoning_command.py tests/gateway/test_reasoning_command.py tests/hermes_cli/test_reasoning_effort_menu.py tests/run_agent/test_run_agent_codex_responses.py -q -o addopts=Fixes #61634