Skip to content

fix(desktop): stop Tip from sticking open and blocking clicks - #61973

Merged
OutThisLife merged 1 commit into
mainfrom
bb/desktop-tip-stuck
Jul 10, 2026
Merged

OutThisLife merged 1 commit into
mainfrom
bb/desktop-tip-stuck

Conversation

@OutThisLife

Copy link
Copy Markdown

Summary

  • Tips were getting stuck open (and blocking titlebar/tab clicks) because Radix keeps hoverable content + a pointer-grace bridge by default — that bridge never clears over Electron -webkit-app-region: drag chrome.
  • Default disableHoverableContent on TooltipProvider, set it explicitly on Tip, and add pointer-events-none on TooltipContent so open state is trigger-hover only and tips never steal pointer events.

Test plan

  • cd apps/desktop && npm run test:ui -- src/components/ui/tooltip.test.tsx
  • Hover a titlebar tool tip, move onto the drag region / neighboring icons — tip dismisses immediately and icons remain clickable
  • Hover a tab with a tip, move to an adjacent tab — tip does not block the switch

Radix's hoverable-content grace area can leave tips stuck over Electron drag regions; disable it and make tip content pointer-events-none so open state tracks the trigger only.
@OutThisLife
OutThisLife merged commit caf557b into main Jul 10, 2026
20 checks passed
@OutThisLife
OutThisLife deleted the bb/desktop-tip-stuck branch July 10, 2026 09:03
@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/desktop Electron desktop app (apps/desktop/*) labels Jul 10, 2026
santhreal pushed a commit to santhreal/hermes-agent that referenced this pull request Jul 13, 2026
…p-stuck

fix(desktop): stop Tip from sticking open and blocking clicks
Gravezzz pushed a commit to Gravezzz/hermes-agent that referenced this pull request Jul 21, 2026
…p-stuck

fix(desktop): stop Tip from sticking open and blocking clicks
leewenjie pushed a commit to leewenjie/hermes-agent that referenced this pull request Aug 7, 2026
…p-stuck

fix(desktop): stop Tip from sticking open and blocking clicks
randlee pushed a commit to randlee/hermes-agent that referenced this pull request Aug 11, 2026
…p-stuck

fix(desktop): stop Tip from sticking open and blocking clicks
melon-xf added a commit to melon-xf/hermes-agent that referenced this pull request Sep 3, 2026
…p-stuck

fix(desktop): stop Tip from sticking open and blocking clicks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/desktop Electron desktop app (apps/desktop/*) P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants