feat(slack): Block Kit buttons for clarify prompts — with tests, chunking, and resolve-state editing

[100yenadmin]

What this does

Slack is the last button-capable platform where the clarify tool still degrades to a numbered text list — Telegram, Discord, and WhatsApp Cloud all render interactive choices. This adds the send_clarify override and Bolt action handlers so Slack users tap a button instead of typing "2".

❓ Which environment should I deploy to?
[staging] [production] [both, staging first] [✏️ Other…]

How it works

• send_clarify renders a Block Kit section (question, mrkdwn-escaped) plus actions rows: one button per choice and a final "✏️ Other…" button. Rows chunk at Slack's five-element cap, so buttons keep working if MAX_CHOICES is raised later (feat(clarify): raise MAX_CHOICES from 4 to 10 #28900).
• Every choice receives a unique hermes_clarify_choice_<idx> action ID, satisfying Slack's per-block uniqueness requirement. One anchored Bolt regex listener routes those indexed IDs; the existing compact clarify_id|idx value and server-side choice lookup remain unchanged.
• A choice click resolves through resolve_gateway_clarify with the exact server-side choice string, then edits the message to show the selection. A msg_ts-keyed guard makes double-clicks inert, following the existing approval-button pattern.
• "Other…" calls mark_awaiting_text; the gateway's platform-agnostic text intercept resolves the next typed message. No new Slack-specific text machinery is introduced.
• Open-ended clarify prompts delegate to the base text path unchanged. Unauthorized clicks are ignored through the same authorization gate used by approval buttons. Expired prompts are edited to show an expiry notice instead of leaving a dead button row.

Event flow

clarify request
  ├─ choices present ──> Block Kit buttons ──> indexed action_id matcher
  │                                           ├─ choice ──> resolve + edit message
  │                                           └─ Other ───> await next text message
  └─ no choices ──────> existing base text path

Relationship to the other open PRs

#51547 and #28885 address the same Slack parity gap. This PR keeps the send and action paths together and adds:

• a 14-case adapter suite covering rendering, values, escaping, thread_ts, resolve behavior, double-click protection, authorization, expiry, Other-to-text capture, chunking, and base fallback;
• action-registration coverage proving the indexed Bolt matcher accepts hermes_clarify_choice_0 and rejects the old unindexed form;
• row chunking instead of falling back to text above four choices;
• post-resolution message editing and expiry notices; and
• current-main compatibility with a Slack-focused diff and no unrelated runtime changes.

This therefore supersedes the earlier alternatives while preserving their intended user experience. The implementation can still be consolidated with either author if maintainers prefer a different landing path.

Review fix

The review finding in discussion_r3593877536 was valid: the original patch reused hermes_clarify_choice within one actions block. Commit 5fb2a2703 assigns indexed IDs, registers an anchored regex listener, preserves value routing, and adds render plus registration regressions. The thread has been answered and resolved.

Validation

Validated on head 5fb2a2703 after syncing with main at 659d1123c:

• scripts/run_tests.sh tests/gateway/test_slack.py tests/gateway/test_slack_clarify_buttons.py — 257 passed;
• cross-platform clarify and Slack approval suite — 126 passed;
• Ruff on all three changed files — clean;
• Python bytecode compilation — clean; and
• git diff --check — clean.

[teknium1]

Thanks for filling a verified Slack parity gap. Current remote main (5ecc079) has no Slack send_clarify override, so Slack inherits the base numbered-text fallback in gateway/platforms/base.py:3088-3143. The PR adds the native Slack send path and action registration in plugins/platforms/slack/adapter.py (PR right-side lines 1191-1195 and 3414-3518), while reusing the existing clarify primitives at tools/clarify_gateway.py:150-227.

GitHub comparison shows that the 87 commits after the PR base did not modify plugins/platforms/slack/adapter.py, and the PR remains mergeable. No blocking correctness issue was found in the reviewed diff.

Automated hermes-sweeper review.

[100yenadmin]

Rebased onto current main (47d853fd) — the CONFLICTING state is resolved (one hunk: main's hermes_feedback action registration landed at the same site as our clarify handlers; both kept).

Worth noting what the rebase surfaced: since this PR was opened, the clarify-buttons pattern standardized on main across Telegram/Discord/WhatsApp — and our Slack override's send_clarify signature is byte-identical to that now-canonical base contract (open-ended prompts delegate to super()). Slack is the one platform still on the numbered-text fallback (gateway/platforms/base.py:3119), so this PR now fills exactly the remaining gap in an established pattern rather than proposing a new one.

Suites re-verified post-rebase via scripts/run_tests.sh: 153 passed, 0 failed (slack clarify buttons 14, clarify gateway 18, clarify tool 28, plus telegram/discord clarify and slack/telegram/discord approval regressions).

On consolidation: #51547 and #28885 target the same gap and remain unrebased against the migrated layout — our offer stands to fold whichever pieces reviewers prefer, but this branch is current, tested, and matches the canonical adapter contract today. A maintainer review would unblock it.

[100yenadmin]

@copilot review

Updated head: 5fb2a2703. The Slack action_id uniqueness review finding is fixed with indexed choice IDs plus an anchored Bolt matcher; routing values remain unchanged. The inline thread is resolved, 257 Slack tests and 126 cross-platform clarify/approval tests pass, and Ruff/compile/whitespace checks are clean.

[teknium1]

Merged via #69318 — your commit was cherry-picked onto current main with your authorship preserved in git history: your implementation (buttons, >5 chunking, resolve-state editing, tests) was the chosen base and was cherry-picked with authorship.

Thanks for the contribution!