Skip to content

fix(desktop): avoid false profile switch resets - #61826

Closed
tingaidehua wants to merge 1 commit into
NousResearch:mainfrom
tingaidehua:fix/desktop-profile-switch-strictmode
Closed

fix(desktop): avoid false profile switch resets#61826
tingaidehua wants to merge 1 commit into
NousResearch:mainfrom
tingaidehua:fix/desktop-profile-switch-strictmode

Conversation

@tingaidehua

Copy link
Copy Markdown

Summary

  • make desktop profile-switch callbacks fire only when the profile value actually changes
  • prevent React StrictMode effect replay from clearing settings state on mount
  • add a regression test for StrictMode replay and real profile changes

Tests

  • npm --workspace apps/desktop run test:ui -- src/app/hooks/use-on-profile-switch.test.tsx
  • npm --workspace apps/desktop exec eslint -- --quiet src/app/hooks/use-on-profile-switch.ts src/app/hooks/use-on-profile-switch.test.tsx
  • npm --workspace apps/desktop run typecheck
  • npm --workspace apps/desktop run build

@tingaidehua

Copy link
Copy Markdown
Author

fix by codex,when develop by dev mode

@alt-glitch alt-glitch added type/bug Something isn't working comp/desktop Electron desktop app (apps/desktop/*) P3 Low — cosmetic, nice to have labels Jul 10, 2026
@teknium1 teknium1 added the sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform label Jul 11, 2026
@teknium1 teknium1 added the area/profiles Multi-profile isolation, HERMES_HOME scoping label Jul 19, 2026
@tingaidehua tingaidehua closed this by deleting the head repository Aug 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/profiles Multi-profile isolation, HERMES_HOME scoping comp/desktop Electron desktop app (apps/desktop/*) P3 Low — cosmetic, nice to have sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants