feat: add BlueBubbles Socket.IO transport - #61808
Closed
cwallace wants to merge 4 commits into
Closed
Conversation
teknium1
reviewed
Jul 10, 2026
teknium1
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the focused Socket.IO transport and lazy-dependency work. One compatibility issue needs correction.
Problems
gateway/platforms/bluebubbles.py:1208adds GUID deduplication in_process_event_payload, which is also called by the webhook handler at line 1084. Therefore default webhook delivery now acknowledges and drops anupdated-messageafter anew-messagewith the same GUID (lines 1219-1221). Current main explicitly registers both webhook events atgateway/platforms/bluebubbles.py:374-377, and its prior handler dispatched each accepted event.
Suggested changes
- Gate this cache on
self.use_socketio, then add a webhook regression test for a same-GUIDnew-message/updated-messagesequence. If suppressing webhook updates is intentional, make that contract explicit and adjust webhook registration/docs accordingly.
Automated hermes-sweeper review.
cwallace
force-pushed
the
wallace/bluebubbles-socketio
branch
from
July 10, 2026 18:01
f9f719a to
61ddfc2
Compare
cwallace
force-pushed
the
wallace/bluebubbles-socketio
branch
from
July 18, 2026 20:19
61ddfc2 to
5d5505d
Compare
added 3 commits
July 28, 2026 14:11
Author
|
After extensive testing this only saved a few milliseconds (on average less than 10ms) per message and was not any more stable than the current webhook method. The extremely small performance improvement was not worth the increased complexity and additional code. I’ve closed the PR and removed the code from my own repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bluebubbles-socketioextraVerification
./venv/bin/python -m py_compile gateway/platforms/bluebubbles.py gateway/run.py tools/lazy_deps.pyscripts/run_tests.sh tests/gateway/test_bluebubbles.py tests/test_project_metadata.py tests/test_packaging_metadata.py -q --tb=short→ 102 passedrequirements_without_aiohttp FalseResourceWarning/ no unclosed aiohttp client sessionNotes
python-socketio.python-socketioand the asyncaiohttpruntime dependency.