fix(agent): add return_exceptions to asyncio.gather in context ref expansion - #61775
Closed
x7peeps wants to merge 1 commit into
Closed
fix(agent): add return_exceptions to asyncio.gather in context ref expansion#61775x7peeps wants to merge 1 commit into
x7peeps wants to merge 1 commit into
Conversation
Collaborator
Related: #59954 (the current open sibling with the same |
Contributor
Author
|
Closing as duplicate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
return_exceptions=Truetoasyncio.gather()inpreprocess_context_references_asyncand guard the result loop againstBaseException.Problem
agent/context_references.pycalledasyncio.gather()withoutreturn_exceptions=True. If one reference expansion (e.g., a URL fetch or file read) fails, the exception propagates immediately and crashes the entire gather, aborting the agent turn — even when other references would have resolved fine.Fix
return_exceptions=Trueto the gather call.isinstance(result, BaseException)and append a warning instead of crashing.Testing