fix(gateway): suppress "(empty)" visible replies on chat surfaces - #6166
Closed
livingghost wants to merge 1 commit into
Closed
fix(gateway): suppress "(empty)" visible replies on chat surfaces#6166livingghost wants to merge 1 commit into
livingghost wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This prevents Hermes from sending the literal string
"(empty)"to messaging platforms when a reasoning-only completion produces no visible user-facing text.Core Hermes intentionally stores reasoning-only completions with
content = "(empty)"so providers and session history keep a non-empty assistant message. That behavior is useful internally, but it leaks a confusing placeholder into Discord and other chat surfaces.This patch keeps the core/session-history behavior unchanged and only suppresses
"(empty)"at the messaging boundary, making it behave like "no reply" for platform delivery.Type of Change
Changes Made
_is_silent_response(...)ingateway/platforms/base.py"(empty)"the same asNone/empty at the platform delivery boundaryrun_agent.pybehavior unchanged, preserving the semantics introduced by fix: accept reasoning-only responses without retries — set content to "(empty)" #5278tests/gateway/test_platform_base.pyfor:"(empty)""(empty)"How to Test
python -m pytest -o addopts= tests/gateway/test_platform_base.py -q"(empty)"Tested on
"(empty)"