Skip to content

fix(agent): name substitute tools in background review deny message to prevent tool-denial storm (#61521) #61618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
webtecnica wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(agent): name substitute tools in background review deny message to prevent tool-denial storm (#61521) #61618

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions agent/background_review.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -817,7 +817,10 @@ def _bg_review_auto_deny(command, description, **kwargs):
review_whitelist,
deny_msg_fmt=(
"Background review denied non-whitelisted tool: "
"{tool_name}. Only memory/skill tools are allowed."
'"{tool_name}". Review mode only permits memory and '
"skill management tools. Use `skill_view` to read a "
"skill, `skill_manage` to modify one, `skills_list` "
"to discover skills, and `memory` for notes."

@teknium1 teknium1 Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

memory is absent from the whitelist when both memory flags are disabled (review_toolsets begins as only skills on current main). Please make this guidance conditional on memory being available, and apply the same condition to the injected review prompt.

),
)
try:
Expand All @@ -839,8 +842,11 @@ def _bg_review_auto_deny(command, description, **kwargs):
user_message=(
prompt
+ "\n\nYou can only call memory and skill "
"management tools. Other tools will be denied "
"at runtime — do not attempt them."
"management tools. Use `skill_view` to read a "
"skill, `skill_manage` to modify one, "
"`skills_list` to discover skills, and `memory` "
"for notes. Other tools will be denied at "
"runtime — do not attempt them."
),
conversation_history=_review_history,
)
Expand Down
Loading