Conversation
bf69a37 to
a0fb33e
Compare
|
Thanks for the focused Telegram delivery fix. The premise remains current: Problems
Suggested changes
Automated hermes-sweeper review. |
a0fb33e to
1d9f8a6
Compare
1d9f8a6 to
be77847
Compare
|
Rebased onto current Import conflict resolved by keeping both This remains the preferred fix for #61569 from the issue reporter: ffprobe metadata, bounded thumbnail, async offload, tests. Competing PRs #61620 / #62019 cover overlapping ground; happy to align if maintainers prefer one of those shapes. Local verification: python -m pytest -q -o 'addopts=' tests/gateway/test_telegram_documents.py
# 49 passed |
be77847 to
ab94611
Compare
|
Rebased onto current Final head: Verification:
|
|
Final verification re-run from the clean rebased worktree confirms the published head is unchanged and complete.
|
Sweeper review on NousResearch#61570 asked for default-mode coverage: stub probe helpers and assert send_video receives duration/width/height/supports_streaming plus an open thumbnail handle on the ordinary multipart path.
ab94611 to
ed520fc
Compare
|
Rebased onto current Preserved current-main Telegram adapter behavior while retaining the video metadata/thumbnail fix. Added/kept coverage for the ordinary multipart path forwarding Local verification on the committed tree:
|
What does this PR do?
Fixes Telegram video delivery so MP4 attachments are sent with the metadata Telegram clients expect for playable video cards.
TelegramAdapter.send_video()now:ffprobeffmpegsendVideowithout the thumbnail if Telegram rejects only the thumbnailasyncio.to_threadsupports_streaming=TrueThis avoids large valid MP4s being accepted by Telegram but rendered in clients as black/empty
00:00download tiles.Related Issue
Fixes #61569
Type of Change
Changes Made
plugins/platforms/telegram/adapter.pysendVideotests/gateway/test_telegram_documents.pysupports_streamingis passed for video sendsHow to Test
python3 -m pytest tests/gateway/test_telegram_documents.py::TestSendVideo -q -o 'addopts='python3 -m pytest tests/gateway/test_telegram_documents.py -q -o 'addopts='python3 -m pytest tests/gateway/test_telegram_max_doc_bytes.py tests/gateway/test_telegram_send_path_health.py -q -o 'addopts='Latest local results after review fixes:
Manual smoke test from my Telegram local Bot API setup returned a normal video object with metadata and thumbnail:
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
N/A
Screenshots / Logs
Direct local Bot API smoke result: