fix(discord): wire voice input callback at adapter connect time - #61407
fix(discord): wire voice input callback at adapter connect time#61407isheng-eqi wants to merge 3 commits into
Conversation
_voice_input_callback was only set in _handle_voice_channel_join, not at adapter connect or reconnect. Voice transcription was logged but never forwarded as an inbound message without explicit /voice join. Wire the callback at both connect and reconnect paths. Fixes NousResearch#60623
…t tests PR NousResearch#61407 accesses self._handle_voice_channel_input in _platform_reconnect_watcher. The test mock runner created via _make_runner() must have this attribute.
|
Thanks for tracing both connection paths. The callback gap is present on current main, but the proposed wiring does not yet make an automatic/programmatic voice join usable end-to-end. Problems
Suggested changes
Automated hermes-sweeper review. |
- Wire adapter._voice_input_callback at connect and reconnect so voice transcription is forwarded without requiring /voice join (NousResearch#60623). - Add optional text_channel_id and source params to DiscordAdapter .join_voice_channel() so automatic/programmatic voice joins can establish the text-channel binding needed by _handle_voice_channel_input. - Add TestVoiceInputCallbackWiring: asserts callback wiring on startup and reconnect for Discord adapters with voice attributes.
6c5c3ad to
e8a9876
Compare
|
Thanks for the thorough review! I've addressed both concerns:
Please take another look! |
…t tests PR #61407 accesses self._handle_voice_channel_input in _platform_reconnect_watcher. The test mock runner created via _make_runner() must have this attribute.
|
Merged into main via consolidated salvage PR #73517 (merge Your contribution is credited to you in git history. Thank you! Closing this PR as merged-via-salvage. |
…t tests PR NousResearch#61407 accesses self._handle_voice_channel_input in _platform_reconnect_watcher. The test mock runner created via _make_runner() must have this attribute.
…t tests PR NousResearch#61407 accesses self._handle_voice_channel_input in _platform_reconnect_watcher. The test mock runner created via _make_runner() must have this attribute.
Fixes #60623
_voice_input_callback was only set in _handle_voice_channel_join, not at adapter connect or reconnect. Voice transcription was logged but never forwarded as an inbound message without explicit /voice join.
Wire the callback at both connect and reconnect paths.