fix(desktop): re-apply UI zoom after minimize/restore on Windows by HexLab98 · Pull Request #61245 · NousResearch/hermes-agent

HexLab98 · 2026-07-09T01:52:10Z

Summary

Re-apply the persisted UI zoom level when a desktop window is shown or restored, fixing Windows minimize/restore snapping back to 100% while Settings still shows 125%/150%.
Wire zoom restore through wireCommonWindowHandlers so secondary session windows get the same lifecycle coverage as the main window.

Test plan

npx tsx --test apps/desktop/electron/zoom.test.ts
Windows: set UI Scale to 125%, minimize, restore — scale should stay at 125%

Chromium can drop webContents zoom when a BrowserWindow is minimized and restored. Re-assert the persisted level on show/restore for every chat window, not only on the initial did-finish-load.

OutThisLife · 2026-07-10T07:13:28Z

Superseded by #61925.

Same core fix (reassert persisted zoom on show/restore + first load, shared via wireCommonWindowHandlers), plus it resolves the open review question from the report thread: the pet overlay is scoped out of global UI zoom (wireCommonWindowHandlers(win, { zoom: false })).

Letting the pet inherit zoom is a bug, not a nicety — it sizes its own OS window to fit the sprite in unzoomed CSS px (overlayWindowSize → setBounds), so a 125% webContents zoom renders the mascot larger than its window and crops it; it also has its own Alt+wheel scale, and it shares the renderer origin's hermes:desktop:zoomLevel key, so your PR would have newly pulled the main window's zoom into the mascot on spawn.

Your pure-helper tests are kept and you're credited via Co-authored-by. Thanks for the fix + the clean installZoomReassertOnWindowEvents helper.

OutThisLife · 2026-07-10T07:13:29Z

Closing in favor of #61925 (adds pet-overlay zoom scoping on current main).

Windows drops webContents zoom on minimize/restore, so the UI snapped back to 100% while Settings still read 125%. Zoom was only reasserted on the main window's did-finish-load, never on show/restore and never for session windows. Reassert the persisted level on show/restore + first load, wired once in wireCommonWindowHandlers so the main window and secondary session windows share it. The pet overlay opts out (zoom:false): it sizes its own OS window to fit the sprite in unzoomed CSS px and has its own Alt+wheel scale, so inheriting the global zoom would render the mascot larger than its window and crop it (and it shares the renderer origin's zoom localStorage key). Salvages #61245; keeps its pure-helper tests and adds a scope assertion. Co-authored-by: HexLab98 <liruixinch@outlook.com>

fix(desktop): re-apply UI zoom on show/restore, scoped to chat windows (supersedes #61245)

Windows drops webContents zoom on minimize/restore, so the UI snapped back to 100% while Settings still read 125%. Zoom was only reasserted on the main window's did-finish-load, never on show/restore and never for session windows. Reassert the persisted level on show/restore + first load, wired once in wireCommonWindowHandlers so the main window and secondary session windows share it. The pet overlay opts out (zoom:false): it sizes its own OS window to fit the sprite in unzoomed CSS px and has its own Alt+wheel scale, so inheriting the global zoom would render the mascot larger than its window and crop it (and it shares the renderer origin's zoom localStorage key). Salvages NousResearch#61245; keeps its pure-helper tests and adds a scope assertion. Co-authored-by: HexLab98 <liruixinch@outlook.com>