Skip to content

fix: keep password dashboard auth on login form - #61178

Closed
Dalvae wants to merge 1 commit into
NousResearch:mainfrom
Dalvae:main
Closed

fix: keep password dashboard auth on login form#61178
Dalvae wants to merge 1 commit into
NousResearch:mainfrom
Dalvae:main

Conversation

@Dalvae

@Dalvae Dalvae commented Jul 8, 2026

Copy link
Copy Markdown

Summary

  • avoid auto-SSO OAuth redirect when the only dashboard auth provider supports password login
  • keep password-only/basic auth on the /login form instead of hitting /auth/login and 500ing
  • add regression coverage for the single password-provider path

Test

  • uv run --with pytest --with fastapi --with starlette --with httpx python -m pytest tests/hermes_cli/test_dashboard_auth_password_login.py -q

@alt-glitch alt-glitch added type/bug Something isn't working comp/dashboard Web dashboard / control panel UI (dashboard/, landing) area/auth Authentication, OAuth, credential pools P2 Medium — degraded but workaround exists duplicate This issue or pull request already exists labels Jul 8, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

This was generated by AI during triage.

Duplicate of #54887 — same code site (_auto_sso_response in hermes_cli/dashboard_auth/middleware.py) and same mechanism (if getattr(provider, "supports_password", False): return None fall-through to the /login form). #54887 is the earliest open fix in the dashboard password-auth 500 cluster (regression from merged #54846). Related: #58171 (broader superset), #59268 (routes.py facet).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/auth Authentication, OAuth, credential pools comp/dashboard Web dashboard / control panel UI (dashboard/, landing) duplicate This issue or pull request already exists P2 Medium — degraded but workaround exists type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants