Skip to content

fix(kanban): surface active PR respawn guards - #61035

Closed
valentin-momboeuf wants to merge 1 commit into
NousResearch:mainfrom
valentin-momboeuf:fix/kanban-active-pr-respawn-guard
Closed

valentin-momboeuf wants to merge 1 commit into
NousResearch:mainfrom
valentin-momboeuf:fix/kanban-active-pr-respawn-guard

Conversation

@valentin-momboeuf

Copy link
Copy Markdown

Summary

  • exclude active-PR guarded ready tasks from spawnable-ready telemetry
  • surface respawn_guarded task/reason entries in dispatch JSON, CLI, daemon, and gateway logs
  • document blocking review-required PR handoffs to avoid ready+active_pr limbo

Test Plan

  • scripts/run_tests.sh tests/hermes_cli/test_kanban_db.py -k 'has_spawnable_ready or respawn_guard' -v
  • scripts/run_tests.sh tests/hermes_cli/test_kanban_cli_dispatch_passthrough.py -v
  • scripts/run_tests.sh tests/hermes_cli/test_kanban_db.py tests/hermes_cli/test_kanban_cli_dispatch_passthrough.py tests/hermes_cli/test_kanban_core_functionality.py -k 'kanban or gateway_dispatcher or dispatch'
  • python3 -m compileall -q gateway/kanban_watchers.py hermes_cli/kanban.py hermes_cli/kanban_db.py

@valentin-momboeuf

valentin-momboeuf commented Jul 8, 2026

Copy link
Copy Markdown
Author

Local verification completed before opening this PR:

  • python3 -m compileall -q gateway/kanban_watchers.py hermes_cli/kanban.py hermes_cli/kanban_db.py
  • scripts/run_tests.sh tests/hermes_cli/test_kanban_db.py -k 'has_spawnable_ready or respawn_guard' -v → 21 passed
  • scripts/run_tests.sh tests/hermes_cli/test_kanban_cli_dispatch_passthrough.py -v → 5 passed
  • scripts/run_tests.sh tests/hermes_cli/test_kanban_db.py tests/hermes_cli/test_kanban_cli_dispatch_passthrough.py tests/hermes_cli/test_kanban_core_functionality.py -k 'kanban or gateway_dispatcher or dispatch' → 398 passed

I attempted to merge after review, but this account lacks direct merge / auto-merge permission on NousResearch/hermes-agent.

@valentin-momboeuf

Copy link
Copy Markdown
Author

Closing/abandoning this PR per Valentin's instruction; this was opened against the wrong upstream for the current need.

@alt-glitch alt-glitch added type/bug Something isn't working comp/cron Cron scheduler and job management P3 Low — cosmetic, nice to have labels Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cron Cron scheduler and job management P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants