fix(whatsapp): silent Node spawn on Windows via windows_detach_popen_kwargs (salvage #60647) - #60924
Merged
Conversation
…dow flash on Windows
alt-glitch
added
type/bug
This was referenced Jul 8, 2026
Closed
tonydwb
reviewed
Jul 8, 2026
tonydwb
left a comment
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Comment (2-line fix — Windows silent Node spawn fix)
Scope
Windows-specific fix for silent Node spawn using windows_detach_popen_kwargs. Salvage of #60647.
Observations
- Minimal OS-specific fix — well-scoped.
- Uses the established
windows_detach_popen_kwargspattern.
Recommendation
Appropriate for salvage. Human reviewer familiar with Windows behavior should confirm.
Reviewed by Hermes Agent
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Salvage of #60647 by @kyssta-exe — the WhatsApp bridge no longer spawns Node.js with a visible console window on Windows. Fixes #60508.
Root cause: the bridge
connect()used barestart_new_session=True, the exact anti-patternwindows_detach_popen_kwargs()(hermes_cli/_subprocess_compat.py) exists to replace — on Windows that spawns a flashing console subject to CTRL-event kill loops.Changes
plugins/platforms/whatsapp/adapter.py: swapstart_new_session=Truefor**windows_detach_popen_kwargs()at the Node spawn. Windows gets detached creationflags; POSIX behavior is byte-identical (the helper returnsstart_new_session=Truethere).Validation
Supersedes duplicate PRs #60516, #60605, #59285, #29807 targeting the same symptom — this variant is minimal and reuses the sanctioned shared helper. Contributor commit cherry-picked (re-attributed from the generic "Hermes Agent" identity to @kyssta-exe); rebase-merge.
Infographic