fix(desktop): register /compress in TUI gateway command.dispatch (salvage #60644) - #60921
Merged
Merged
Conversation
…esktop can invoke it
…nd.dispatch Ported from #60834 (same author) — pending-input routing so clients that fail the slash.exec->dispatch fallback still reach the new compress handler.
alt-glitch
added
type/bug
tonydwb
reviewed
Jul 8, 2026
tonydwb
left a comment
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Comment (68 additions — register /compress in TUI gateway command.dispatch)
Scope
Registers the /compress command in the TUI gateway command dispatcher. Salvage of #60644.
Observations
- Small feature addition.
- Salvage PR referencing #60644.
- No obvious concerns.
Recommendation
Small scope. Human reviewer should confirm the salvage relationship and that the dispatch registration is correct.
Reviewed by Hermes Agent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Salvage of #60644 by @kyssta-exe — the Desktop app can now invoke
/compress: the TUI gateway'scommand.dispatchgains acompress/compacthandler. Fixes #60603 ("/compress · error").Root cause: Desktop routes
/compressviaslash.exec→ fallbackcommand.dispatch, which had no handler and fell to error 4018; no desktop-side path called the existingsession.compressRPC.Changes
tui_gateway/server.py:compress/compacthandler incommand.dispatchmirroring thesession.compressRPC — delegates to the shared_compress_session_historypipeline with busy guard,session.infoemit, and_sync_session_key_after_compress(compression rotates the SessionDB session id)compress/compactadded to_PENDING_INPUT_COMMANDSso clients that fail the slash.exec→dispatch fallback still route correctly — ported from the author's own fix(tui): route /compress through command.dispatch with server-side compression #60834 before closing itValidation
scripts/run_tests.sh tests/tui_gateway/_err(4018, ...), exactly the #60603 errorContributor commit cherry-picked (re-attributed from the generic "Hermes Agent" committer identity to @kyssta-exe); rebase-merge to preserve authorship.
Infographic