Skip to content

fix(serve): emit both HERMES_DASHBOARD_READY and HERMES_BACKEND_READY for backward compatibility #60763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liuhao1024 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(serve): emit both HERMES_DASHBOARD_READY and HERMES_BACKEND_READY for backward compatibility #60763

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions hermes_cli/web_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16823,11 +16823,15 @@ async def _serve():
app.state.bound_port = actual_port

_write_dashboard_ready_file(actual_port)
# Port-discovery sentinel parsed by the desktop spawn. `serve` is a
# plain backend, not a dashboard, so it announces a neutral token;
# `dashboard` keeps the legacy one. The desktop matches either.
ready_token = "HERMES_BACKEND_READY" if headless else "HERMES_DASHBOARD_READY"
print(f"{ready_token} port={actual_port}", flush=True)
# Port-discovery sentinel parsed by the desktop spawn. During the
# transition period (post-#55923), emit both tokens so pre-#55923
# desktop builds can still match the legacy sentinel while new
# builds use the neutral one. This avoids breaking users who run
# `hermes update` (CLI-only) without rebuilding the desktop app.
# The desktop regex already matches either sentinel since #55923.
print(f"HERMES_DASHBOARD_READY port={actual_port}", flush=True)
if headless:
print(f"HERMES_BACKEND_READY port={actual_port}", flush=True)
if headless:
# No SPA, and the JSON-RPC/WS endpoints are auth-gated — don't
# advertise a paste-and-connect URL, just announce the bind.
Expand Down
Loading