Repository navigation
Conversation
…ch#60432) /update spawned the update helper via setsid but did NOT call request_restart(), so the gateway exited without running the drain phase. This killed active cron jobs and tool subprocesses mid-work. Fix: call request_restart() after spawning the update helper, same as /restart does. This triggers stop() -> _drain_active_agents() with the configured restart_drain_timeout, giving in-flight work a graceful drain window. Closes NousResearch#60432
This was referenced Jul 8, 2026
Collaborator
|
Thanks for the focused investigation and the clear comparison with Automated hermes-sweeper review found that the behavioral guarantee is already present on current
Closing as implemented on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/updatespawned the update helper viasetsidbut did NOT callrequest_restart(), so the gateway exited without running the drain phase (active_at_start=0, drain took 0.00s). This killed active cron jobs and tool subprocesses mid-work.A production incident with the Daily family briefing during
/updateshowed the more severe failure mode: the cron job started, then never logged completion or delivery.Fix
Call
request_restart()after spawning the update helper, same as/restartdoes. This triggersstop() -> _drain_active_agents()with the configuredrestart_drain_timeout, giving in-flight work a graceful drain window before the gateway process exits.Comparison: /restart vs /update (before fix)
request_restart()stop() -> _drain_active_agents()restart_drain_timeoutrestart_drain_timeoutCloses #60432