Skip to content

fix(security): bump starlette 1.0.1 → 1.3.1 (GHSA-82w8-qh3p-5jfq, GHSA-jp82-jpqv-5vv3) - #60676

Closed
AIalliAI wants to merge 2 commits into
NousResearch:mainfrom
AIalliAI:fix/starlette-cve-bump
Closed

AIalliAI wants to merge 2 commits into
NousResearch:mainfrom
AIalliAI:fix/starlette-cve-bump

Conversation

@AIalliAI

@AIalliAI AIalliAI commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Summary

Bump pinned starlette from 1.0.1 to 1.3.1 across all extras (dev, mcp, computer-use, web).

CVEs Fixed

CVE Severity Description
GHSA-82w8-qh3p-5jfq CVSS 7.5 request.form() limits silently ignored → DoS
GHSA-jp82-jpqv-5vv3 CVSS 5.3 Unvalidated request path poisons url.hostname
GHSA-x746-7m8f-x49c CVSS 7.5 StaticFiles SSRF via UNC paths (Windows)
GHSA-wqp7-x3pw-xc5r CVSS 5.3 Arbitrary HTTP method dispatch via getattr

All fixed in starlette 1.3.1. fastapi 0.133.1 remains compatible.

Files Changed

  • pyproject.toml — 4 pin sites updated (dev, mcp, computer-use, web)
  • uv.lock — resolved starlette 1.3.1

No code changes — pin-only bump.

@AIalliAI
AIalliAI requested a review from a team July 8, 2026 03:47
…HSA-jp82-jpqv-5vv3

starlette 1.0.1 is vulnerable to:
- GHSA-82w8-qh3p-5jfq: request.form() limits silently ignored, enabling DoS (CVSS 7.5)
- GHSA-jp82-jpqv-5vv3: unvalidated request path poisons url.hostname (CVSS 5.3)
- GHSA-x746-7m8f-x49c: StaticFiles SSRF via UNC paths on Windows (CVSS 7.5)
- GHSA-wqp7-x3pw-xc5r: Arbitrary HTTP method dispatch via getattr (CVSS 5.3)

All fixed in starlette 1.3.1. Bumped in dev, mcp, computer-use, and web extras.
fastapi 0.133.1 remains compatible.
@AIalliAI
AIalliAI force-pushed the fix/starlette-cve-bump branch from ed8fce5 to 70ba65c Compare July 8, 2026 03:49
@alt-glitch alt-glitch added type/security Security vulnerability or hardening area/config Config system, migrations, profiles dependencies Pull requests that update a dependency file python:uv Pull requests that update python:uv code sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades P2 Medium — degraded but workaround exists labels Jul 8, 2026
@alt-glitch

Copy link
Copy Markdown
Contributor

This was generated by AI during triage.

Related to the June/July-2026 dependency-CVE cluster — this is part of an overlapping set of consolidated pin bumps. Other open PRs bumping starlette 1.0.1 -> 1.3.1 (and adjacent CVE pins) for the same OSV/Dependabot findings: #56830, #59993, #47998 (tracking #47997). These are competing/overlapping, not duplicates — a maintainer should pick a single canonical consolidated dependency bump. Defense-in-depth dependency hygiene (out-of-scope per SECURITY.md §3.2, no §3.1 boundary crossing / PoC), so priced P2 on ordinary merits, not escalated by the security label.

@egilewski

Copy link
Copy Markdown
Contributor

suggesting changes

CI is currently failing on this PR head in All required checks pass, Python tests / Run tests slice 5/8, Python tests / Run tests slice 3/8. The comparable current main status is not failing for those check(s), so deeper review should wait for the PR-specific required-check failure to be fixed.

Please fix or rerun the failing check, then push a new head or ask for re-review.

Signed: GPT-5.5-low in Codex

@AIalliAI
AIalliAI force-pushed the fix/starlette-cve-bump branch from 04b86bf to 10063d4 Compare July 8, 2026 04:58
…o match pyproject.toml

CI caught pin mismatch between pyproject.toml (1.3.1) and lazy_deps.py (still
1.0.1). The CVE bump in NousResearch#60676 updated pyproject.toml but missed the lazy_deps
counterpart. Both dashboard and computer_use entries now match at 1.3.1.
@AIalliAI
AIalliAI force-pushed the fix/starlette-cve-bump branch from 10063d4 to bdbb5f5 Compare July 8, 2026 05:13
@AIalliAI

AIalliAI commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by dependabot PR #46870 which covers the same starlette bump.

@AIalliAI AIalliAI closed this Jul 8, 2026
@AIalliAI
AIalliAI deleted the fix/starlette-cve-bump branch July 8, 2026 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Config system, migrations, profiles dependencies Pull requests that update a dependency file P2 Medium — degraded but workaround exists python:uv Pull requests that update python:uv code sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades type/security Security vulnerability or hardening

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants