fix: make /skills slash command available in desktop and dashboard - #60550
Open
AIalliAI wants to merge 1 commit into
Open
fix: make /skills slash command available in desktop and dashboard#60550AIalliAI wants to merge 1 commit into
AIalliAI wants to merge 1 commit into
Conversation
alt-glitch
added
type/bug
AIalliAI
force-pushed
the
fix/skills-cli-only
branch
2 times, most recently
from
July 8, 2026 17:07
af58e40 to
a6bd67d
Compare
AIalliAI
force-pushed
the
fix/skills-cli-only
branch
from
July 11, 2026 02:56
7e3fb97 to
5f5c1e4
Compare
teknium1
reviewed
Jul 15, 2026
teknium1
left a comment
teknium1
left a comment
Contributor
There was a problem hiding this comment.
Thanks for pursuing the skill-write approval workflow. The current one-line registry change is not sufficient for the reported Desktop issue and changes the gateway gate semantics.
Problems
hermes_cli/commands.py:178: removingcli_only=Truemakes/skillsunconditionally gateway-available because_is_gateway_available()returns early for non-CLI-only commands athermes_cli/commands.py:449-453;skills.write_approvalis no longer consulted for visibility.- Desktop still rejects
/skills: it is deliberately marked as a settings-owned unavailable command inapps/desktop/src/lib/desktop-slash-commands.ts:221, and execution is blocked at lines 291-299. This does not provide the sidebar pending/diff/approve/reject flow requested in #60442. - Dashboard does not require this change:
tui_gateway/server.py:11762-11764already catalogs commands without filteringcli_only.
Suggested changes
- Keep
cli_only=Trueto preserve the existing config-gated gateway behavior. - Re-scope the change to a Desktop Skills-sidebar review surface, with targeted tests for pending entries, diff rendering, approval, and rejection.
- Drop the unrelated
scripts/release.pyand approval-test changes.
Automated hermes-sweeper review.
| @@ -175,7 +175,7 @@ class CommandDef: | |||
| CommandDef("toolsets", "List available toolsets", "Tools & Skills", | |||
| cli_only=True), | |||
| CommandDef("skills", "Search, install, inspect, or manage skills", | |||
| "Tools & Skills", cli_only=True, | |||
| "Tools & Skills", | |||
Contributor
There was a problem hiding this comment.
Removing cli_only=True bypasses skills.write_approval: _is_gateway_available() returns True for every non-CLI-only command at hermes_cli/commands.py:449 before it reaches the config-gate branch. Please retain cli_only=True; the existing gate already makes this command gateway-dispatchable when enabled.
teknium1
added
sweeper:risk-security-boundary
…, keep cli_only=True Address PR NousResearch#60550 review comments correctly: - Keep cli_only=True on the /skills CommandDef (revert the incorrect removal) — _is_gateway_available() needs cli_only to route through gateway_config_gate=skills.write_approval for proper visibility gating. - Remove /skills from NO_DESKTOP_SURFACE.settings in desktop slash commands so Desktop no longer blocks it as a settings-owned command. - Add /skills as an exec() entry in DESKTOP_COMMAND_SPECS with args:true so the typed subcommands (pending, approve, reject, diff, approval) work naturally in the desktop slash palette. - Update targeted tests: assert /skills resolves as exec surface, is suggested, is executable, has no unavailable message, and args is true. The existing gateway_config_gate="skills.write_approval" continues to gate the command behind the config flag — users must explicitly enable skills.write_approval for /skills to surface in gateway sessions. Closes NousResearch#60442
AIalliAI
force-pushed
the
fix/skills-cli-only
branch
from
July 26, 2026 12:41
5f5c1e4 to
01c2304
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove cli_only=True from the /skills CommandDef so the
pending, approve, reject, diff, and approval subcommands are
accessible in gateway sessions (Desktop App, Dashboard) as well
as CLI.
The existing gateway_config_gate="skills.write_approval" still
gates the command behind the config flag.
Files changed
Closes #60442