feat(mattermost): add rich markdown support for formatted messages (#59401) - #60464
Open
webtecnica wants to merge 1 commit into
Open
feat(mattermost): add rich markdown support for formatted messages (#59401)#60464webtecnica wants to merge 1 commit into
webtecnica wants to merge 1 commit into
Conversation
(cherry picked from commit e73cbb04208ba31b61fc01d782ffa07a35cc7dcc)
webtecnica
force-pushed
the
feat/59401-mattermost-markdown
branch
from
July 11, 2026 12:49
e73cbb0 to
172e903
Compare
teknium1
reviewed
Jul 15, 2026
teknium1
left a comment
Contributor
There was a problem hiding this comment.
Thanks for covering the Mattermost gateway and its standalone sender consistently.
Problems
- Required CI is currently red:
tests/tools/test_send_message_missing_platforms.py:115still asserts the old exact standalone payload, while the changed_standalone_sendpayload now includesprops.format. The failed required slice reportsTestSendMattermost.test_success. - This PR says it closes #59401, but that issue requests an opt-in
mattermost.rich_markdown/extended_markdownconfiguration and a Mattermost-flavored Markdown transformer. Currentformat_message()already preserves standard Markdown atplugins/platforms/mattermost/adapter.py:476-484; this diff only adds REST payload properties and does not add the requested config or transformation.
Suggested changes
- Update the exact-payload test and add coverage for the changed adapter send paths.
- Either rescope the PR away from closing #59401 or implement the issue's requested opt-in behavior.
Automated hermes-sweeper review.
| @@ -1071,6 +1075,7 @@ async def _standalone_send( | |||
| payload: Dict[str, Any] = { | |||
Contributor
There was a problem hiding this comment.
Please update the standalone sender's exact-payload assertion at tests/tools/test_send_message_missing_platforms.py:115. Required CI currently fails because it still expects only channel_id and message; include the intended props contract in that test.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add rich markdown support for Mattermost platform. Adds
"props": {"format": "markdown"}to all post payloads. Closes #59401