Skip to content

Fix BasicAuth dashboard authentication redirect - #60449

Closed
leveragingmaven wants to merge 1 commit into
NousResearch:mainfrom
leveragingmaven:basic-auth-fix
Closed

Fix BasicAuth dashboard authentication redirect#60449
leveragingmaven wants to merge 1 commit into
NousResearch:mainfrom
leveragingmaven:basic-auth-fix

Conversation

@leveragingmaven

Copy link
Copy Markdown

Fixes the dashboard login flow when BasicAuthProvider is the only configured provider.

Changes:

  • Skip OAuth redirect for password-only providers.
  • Return HTTP 400 instead of HTTP 500 when a provider does not implement OAuth login.

This prevents the dashboard from redirecting BasicAuth users into an unsupported OAuth flow.

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/cli CLI entry point, hermes_cli/, setup wizard area/auth Authentication, OAuth, credential pools duplicate This issue or pull request already exists labels Jul 7, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

This was generated by AI during triage.

Duplicate of #54887 — the middleware.py change here is the same supports_password early-return in _auto_sso_response as the canonical open fix #54887 (into which #54958/#55133/#56306/#56639/#57402/#57797/#57214/#57927 already dedup). The extra routes.py NotImplementedError→400 handler mirrors #55988's route-level guard. Related: anchor issue #55130, #55988, and the regression source #54846. Marking as duplicate; maintainer to pick the canonical fix.

@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the focused dashboard-auth fix. This is now implemented on current main; this is an automated hermes-sweeper review.

@teknium1 teknium1 closed this Jul 15, 2026
@teknium1 teknium1 added the sweeper:implemented-on-main Sweeper: behavior already present on current main label Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/auth Authentication, OAuth, credential pools comp/cli CLI entry point, hermes_cli/, setup wizard duplicate This issue or pull request already exists P2 Medium — degraded but workaround exists sweeper:implemented-on-main Sweeper: behavior already present on current main type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants