fix(desktop): trim session-list payloads - #60436
Closed
sitkarev wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Closing in favor of #60883 (merged) — it covers this PR's field-trim (via #43653's strip + #47437's SQL-level |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
system_prompt/model_configfields from/api/sessionsand/api/profiles/sessionslist payloadsWhy
On a real Desktop profile with many long-running/compressed sessions, each sidebar refresh returned full cached prompts for ~50 rows. That made responses multi-megabyte, pegged the single
hermes servebackend at ~100% CPU, and caused/api/status/ navigation to time out.Observed locally before the fix:
/api/statustimed outAfter the fix on the same profile:
/api/status: 200 in ~0.09s/api/sessions?limit=50&offset=0&min_messages=1&archived=exclude&order=recent: ~64KB in ~0.26ssystem_prompt/model_configfields in list rowsTests
uv run python -m pytest tests/hermes_cli/test_web_server.py -k 'sessions and (heavy_internal_prompt_fields or tags_default_profile or forwards_min_messages or order_recent)' -quv run python -m py_compile hermes_cli/web_server.py tests/hermes_cli/test_web_server.py