fix(compression): dedup duplicate tool_call_ids to prevent HTTP 400 on strict providers - #60398
Closed
isheng-eqi wants to merge 3 commits into
Closed
isheng-eqi wants to merge 3 commits into
isheng-eqi wants to merge 3 commits into
Conversation
…n strict providers After context compression, a single tool_call_id can appear in multiple tool messages (original result survives in the tail while the summary re-inserts a back-reference). Strict providers like DeepSeek reject this with HTTP 400 'Duplicate value for tool_call_id', aborting the session. Extend _sanitize_tool_pairs() with a dedup pass that keeps only the last occurrence of each tool_call_id. Walks the message list in reverse so the most recent result (closest to the tail) is always preserved. Fixes NousResearch#58327
…n strict providers After context compression, a single tool_call_id can appear in multiple tool messages (original result survives in the tail while the summary re-inserts a back-reference). Strict providers like DeepSeek reject this with HTTP 400 'Duplicate value for tool_call_id', aborting the session. Extend _sanitize_tool_pairs() with a dedup pass that keeps only the last occurrence of each tool_call_id. Walks the message list in reverse so the most recent result (closest to the tail) is always preserved. Fixes NousResearch#58327
alt-glitch
added
type/bug
Collaborator
|
Thanks for the focused compression investigation. Automated hermes-sweeper review found this behavior is already implemented on
Closing as implemented on main. |
teknium1
added
the
sweeper:implemented-on-main
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a context compression bug where duplicate
tool_call_idvalues survive into the post-compression message list, causing strict providers (DeepSeek) to reject the API call with HTTP 400 and abort the session.Related Issue
Fixes #58327
Type of Change
Changes Made
agent/context_compressor.py: Add dedup pass to_sanitize_tool_pairs()that removes duplicate tool results sharing the sametool_call_id, keeping only the last occurrencetests/agent/test_context_compressor_tool_dedup.py: 6 tests covering duplicates, no-op, dedup+orphan interactionHow to Test