Skip to content

fix(skills): allow absolute skill paths that resolve within trusted directories (#59824) #60195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
webtecnica wants to merge 1 commit into from
Closed

fix(skills): allow absolute skill paths that resolve within trusted directories (#59824) #60195

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion tools/skills_tool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,20 @@ def _skill_lookup_path_error(name: str) -> Optional[str]:
or PureWindowsPath(candidate).is_absolute()
or PureWindowsPath(candidate).drive
):
return "Skill name must be a relative path within the skills directory."
# Allow absolute paths that resolve within trusted directories.
# Cron jobs legitimately store absolute paths for skills outside
# ~/.hermes/skills/ (e.g. symlinked trading-skills repos or
# profile-scoped directories).
from hermes_constants import get_hermes_home

_hermes_home = get_hermes_home()
_trusted_roots = (
str(_hermes_home / "skills") + "/",
str(_hermes_home / "profiles") + "/",
)
resolved = str(Path(candidate).resolve())
if not resolved.startswith(_trusted_roots):
return "Skill name must be a relative path within the skills directory."
if has_traversal_component(candidate):
return "Skill name cannot contain '..' path traversal components."
return None
Expand Down
Loading