docs(auth): scrub Fly.io host detail from quarantine-log comment - #60145
Merged
Conversation
hermes-agent is public/OSS; the forensic-logging comment in
_quarantine_nous_oauth_state named 'Fly' (the specific managed-hosting compute
provider) twice. Reword generically ('a hosted agent', 'a managed log drain may
be WARNING-only') — the behaviour is unchanged, only the comment. Follows the
same scrub applied to the boot re-seed helper (#59983) before merge; this one
slipped through in #59976.
alt-glitch
added
type/docs
Gravezzz
pushed a commit
to Gravezzz/hermes-agent
that referenced
this pull request
Jul 21, 2026
…sResearch#60145) hermes-agent is public/OSS; the forensic-logging comment in _quarantine_nous_oauth_state named 'Fly' (the specific managed-hosting compute provider) twice. Reword generically ('a hosted agent', 'a managed log drain may be WARNING-only') — the behaviour is unchanged, only the comment. Follows the same scrub applied to the boot re-seed helper (NousResearch#59983) before merge; this one slipped through in NousResearch#59976.
randlee
pushed a commit
to randlee/hermes-agent
that referenced
this pull request
Aug 11, 2026
…sResearch#60145) hermes-agent is public/OSS; the forensic-logging comment in _quarantine_nous_oauth_state named 'Fly' (the specific managed-hosting compute provider) twice. Reword generically ('a hosted agent', 'a managed log drain may be WARNING-only') — the behaviour is unchanged, only the comment. Follows the same scrub applied to the boot re-seed helper (NousResearch#59983) before merge; this one slipped through in NousResearch#59976.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
hermes-agentis the public/OSS repo. The forensic-logging comment added in #59976 (_quarantine_nous_oauth_stateinhermes_cli/auth.py) named Fly — the specific managed-hosting compute provider — twice:A NAS-hosted Fly agent can take a terminal invalid_grant…The Fly log drain is WARNING-only…That's a Hermes Cloud infrastructure detail that shouldn't be exposed in public source. The same scrub was applied to the boot re-seed helper (#59983) before it merged; this instance slipped through in #59976.
What
Comment-only reword, behaviour unchanged:
A NAS-hosted Fly agent→A hosted agentThe Fly log drain is WARNING-only→A managed log drain may be WARNING-only("NAS" / "hosted agent" are already normalized throughout the public repo — 13+ pre-existing references — so only the Fly host detail is scrubbed.)
Tests
tests/hermes_cli/test_quarantine_forensic_logging.py— 5/5 still pass (comment-only change).Review lane
Touches
hermes_cli/auth.py→ Teknium's runtime-auth review lane.