feat: add uninstall dry-run mode [salvage #46359] - #60111
Merged
Conversation
Port from nanocoai/nanoclaw#2719: let operators preview the uninstall plan without stopping services or deleting files.
alt-glitch
added
type/feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hermes uninstall --dry-runprints the full uninstall plan without stopping services or deleting files.Salvage of #46359 (branch was 3007 commits stale; cherry-picked cleanly onto current main, authorship preserved).
Changes
hermes_cli/subcommands/uninstall.py: add--dry-runflaghermes_cli/uninstall.py: early-return_print_uninstall_dry_run()— non-mutating plan covering gateway cleanup, PATH cleanup, wrappers/symlinks, GUI artifacts, code checkout, and data removal/preservation (incl. named-profile enumeration under--full)tests/hermes_cli/test_uninstall_dry_run.py: dry-run skips_perform_uninstall; parser accepts the flagValidation
scripts/run_tests.sh tests/hermes_cli/test_uninstall_dry_run.py tests/hermes_cli/test_uninstall_node_symlinks.py tests/hermes_cli/test_gui_uninstall.pyInfographic