feat(tts): allow per-call provider override - #60059
Closed
0xAdamFortuna wants to merge 1 commit into
Closed
0xAdamFortuna wants to merge 1 commit into
0xAdamFortuna wants to merge 1 commit into
Conversation
Allow text_to_speech callers to override the configured provider for a single request without changing global configuration.
0xAdamFortuna
force-pushed
the
adam/tts-provider-override
branch
from
July 7, 2026 09:33
d7e766f to
6dc7f38
Compare
teknium1
reviewed
Jul 15, 2026
teknium1
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for splitting out the TTS work. The new seam is not yet reachable from an actual Hermes TTS invocation.
Problems
tools/tts_tool.py:2284addsprovider_override, but the registered tool schema still accepts onlytextandoutput_path(tools/tts_tool.py:2999-3015), and the handler forwards only those fields (tools/tts_tool.py:3022-3024). The new test covers a direct helper call, not the tool path.- No existing system-owned caller uses the override: gateway auto-TTS still invokes the helper without it in
gateway/platforms/base.py:5025-5027andgateway/run.py:13309-13311.
Suggested changes
- Wire a named existing internal consumer that requires this selection and test that end-to-end, or remove the unused seam.
- Keep provider selection out of the model schema unless its documented user-configured ownership (
tools/tts_tool.py:3001) is intentionally changed.
Automated hermes-sweeper review.
| def text_to_speech_tool( | ||
| text: str, | ||
| output_path: Optional[str] = None, | ||
| provider_override: Optional[str] = None, |
Collaborator
There was a problem hiding this comment.
provider_override is not forwarded by the registered text_to_speech handler, whose current schema exposes only text and output_path (tools/tts_tool.py:2999-3024); no in-tree caller passes this argument either. Please wire a concrete system-owned consumer and test that path, or avoid adding an unused seam.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
Notes