Skip to content

fix(slack): warn when slack_tokens.json is group/world-readable #60009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AlexFucuson9 wants to merge 1 commit into from
Closed

fix(slack): warn when slack_tokens.json is group/world-readable #60009

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions plugins/platforms/slack/adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -985,6 +985,19 @@ async def connect(self, *, is_reconnect: bool = False) -> bool:
tokens_file = get_hermes_home() / "slack_tokens.json"
if tokens_file.exists():
try:
# Warn if the token file is world- or group-readable — it
# contains plaintext bot tokens for all saved workspaces.
import stat as _stat

mode = tokens_file.stat().st_mode
if mode & (_stat.S_IRGRP | _stat.S_IROTH):
logger.warning(
"[Slack] %s is group/world-readable (mode 0%o). "
"Run: chmod 600 %s",
tokens_file.name,
_stat.S_IMODE(mode),
tokens_file,
)
saved = json.loads(tokens_file.read_text(encoding="utf-8"))
for team_id, entry in saved.items():
tok = entry.get("token", "") if isinstance(entry, dict) else ""
Expand Down